> Creates a new, narrowed API explicitly for use by jlink, which view the > resource entries in a jimage file without the re-mapping of names and > invention of synthetic entries inherent in ImageReader. > > Another good reason to express this new API as something other than > ImageReader is that, to fix issues such as > [JDK-8357249](https://bugs.openjdk.org/browse/JDK-8357249), we don't want to > have the (System)ImageReader class used directly in jlink code. It's just the > wrong abstraction and will make it harder to refactor jlink to use a > non-singleton API with a controlled lifetime later. > > I've not added unit tests for the new API (yet), but the fact the > PackagedModulesVsRuntimeImageLinkTest passes with preview content in the > jimage file means that it's working as expected.
David Beaumont has updated the pull request incrementally with two additional commits since the last revision: - Copyright fix - Copyright fix ------------- Changes: - all: https://git.openjdk.org/valhalla/pull/1721/files - new: https://git.openjdk.org/valhalla/pull/1721/files/a27a2883..85670387 Webrevs: - full: https://webrevs.openjdk.org/?repo=valhalla&pr=1721&range=09 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1721&range=08-09 Stats: 4 lines in 2 files changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/valhalla/pull/1721.diff Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1721/head:pull/1721 PR: https://git.openjdk.org/valhalla/pull/1721
