On Wed, 29 Oct 2025 12:22:07 GMT, Coleen Phillimore <[email protected]> wrote:
> Looks good! Small nit though, maybe EnableValhalla should be before > Arguments::enable_preview() since that's the pattern in the rest of the code > that we're going to be looking for when we figure out how to resolve this > option (remove or keep). I'm not sure what you mean by this since the other cases that check for preview and valhalla are in this order: `Arguments::enable_preview() && EnableValhalla` You can see that pattern in cdsConfig and arguments.cpp. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/1698#issuecomment-3462394144
