On Thu, 23 Oct 2025 20:18:42 GMT, Matias Saavedra Silva <[email protected]>
wrote:
> The method add_migrated_value_classes() is being called in non-preview mode
> leading to an assert due to the expected classes not being present in the AOT
> cache. The check for `EnableValhalla` is replaced with a check for preview
> mode. Verified with tier 1-5 tests.
src/hotspot/share/classfile/systemDictionary.cpp line 215:
> 213: } else {
> 214: ClassLoaderData* cld =
> ClassLoaderDataGraph::find_or_create(class_loader);
> 215: if (CDSConfig::is_valhalla_preview()) {
Since this method was refactored to not be only CDS, I think you should use
Arguments::enable_preview() as the test instead of the CDS specific test.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1698#discussion_r2461390638
