On Thu, 9 Oct 2025 20:03:49 GMT, David Beaumont <[email protected]> wrote:
>> src/java.base/share/native/libjimage/jimage.cpp line 114: >> >>> 112: size_t preview_infix_len = strlen(preview_infix); >>> 113: >>> 114: // TBD: assert(module_name_len > 0 && "module name must be >>> non-empty"); >> >> TBD: is obsolete? > > I don't use multiple white-space, so this wasn't me. It's just line 113 in > the old code moved. > I don't know enough to change it confidently. The assert is live, so the comment can be removed. non-empty module name seems like the correct assertion. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1618#discussion_r2429496535
