On Tue, 21 Oct 2025 18:21:40 GMT, Roger Riggs <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reorganising to catch preview-only cases
>
> src/hotspot/share/classfile/classLoader.cpp line 1522:
>
>> 1520: if (jimage_exists()) {
>> 1521: jimage_init(enable_preview);
>> 1522: }
>
> This silently ignores enable_preview if there there is no open image.
> Is it only the exploded build that will not have an open image?
> Should there be an assert on the false branch of `jimage_exists`?
Interesting question. I'll have a think.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1618#discussion_r2455229688
