On Wed, 3 Sep 2025 17:48:59 GMT, Coleen Phillimore <[email protected]> wrote:
>> Frederic Parain has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 67 commits: >> >> - Merge branch 'array_klasses' of github.com:fparain/valhalla into >> array_klasses >> - Forgot a TODO >> - Small cleanup >> - Merge remote-tracking branch 'upstream/lworld' into array_klasses >> - Moved get_Klass() back to protected and updated usages >> - Merge branch 'array_klasses' of github.com:fparain/valhalla into >> array_klasses >> - Linked TODOs to JDK-8366668 >> - Multidim array fix >> - Cleanup T_FLAT_ELEMENT related code >> - Fix for isAssignableFrom + tests >> - ... and 57 more: >> https://git.openjdk.org/valhalla/compare/22e9d5f5...527a17b6 > > src/hotspot/share/oops/refArrayKlass.hpp line 77: > >> 75: >> 76: public: >> 77: static RefArrayKlass *cast(Klass *k) { > > Should the cast function supposed to have an precond(is_refArray_klass()); > before casting? Yes, it should. Fixed. > src/hotspot/share/oops/typeArrayKlass.cpp line 41: > >> 39: #include "oops/typeArrayKlass.inline.hpp" >> 40: #include "oops/typeArrayOop.inline.hpp" >> 41: #include "runtime/arguments.hpp" > > Is this include needed? Yes, there's a call to Arguments::enable_preview() ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1452#discussion_r2323299109 PR Review Comment: https://git.openjdk.org/valhalla/pull/1452#discussion_r2323303214
