On Thu, 4 Sep 2025 06:54:46 GMT, David Simms <[email protected]> wrote:
>> Frederic Parain has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 67 commits: >> >> - Merge branch 'array_klasses' of github.com:fparain/valhalla into >> array_klasses >> - Forgot a TODO >> - Small cleanup >> - Merge remote-tracking branch 'upstream/lworld' into array_klasses >> - Moved get_Klass() back to protected and updated usages >> - Merge branch 'array_klasses' of github.com:fparain/valhalla into >> array_klasses >> - Linked TODOs to JDK-8366668 >> - Multidim array fix >> - Cleanup T_FLAT_ELEMENT related code >> - Fix for isAssignableFrom + tests >> - ... and 57 more: >> https://git.openjdk.org/valhalla/compare/22e9d5f5...527a17b6 > > src/hotspot/share/oops/objArrayKlass.cpp line 159: > >> 157: ArrayDescription ObjArrayKlass::array_layout_selection(Klass* element, >> ArrayProperties properties) { >> 158: // TODO FIXME: the layout selection should take the array size in >> consideration >> 159: // to avoid creation of arrays too big to be handled by the VM > > There is a related bug (though it is old): > [8233189](https://bugs.openjdk.org/browse/JDK-8233189), perhaps we need a new > bug noted here (and relate the old one) Comment and CR have been updated. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1452#discussion_r2322930580
