Thank you Jakob, it built successfully with your change, now I just have to link to it.
On Tue, 29 Oct 2019 at 16:57, Jakob Gruber <jgru...@chromium.org> wrote: > Set > > v8_use_external_startup_data = false > > to compile the snapshot into the binary. I don't think there's any reason > external snapshots would not work in monolithic builds. The assert is > likely guarding the fact that the build produces exactly one single file. > > On Tue, Oct 29, 2019 at 7:07 AM Ben Ernst <boi...@gmail.com> wrote: > >> Following some frustrations with dynamic linking to V8, I thought I'd try >> the static linked build. >> >> My platform is VS2017, Windows 10. >> >> My arguments to "gn" (via "v8gen") are as follows: >> >> treat_warnings_as_errors=false >> is_component_build=false >> v8_enable_i18n_support=false >> v8_use_snapshot=true >> v8_monolithic=true >> >> When I try to build V8, I get this error: >> >> [exec] >> ********************************************************************** >> [exec] ** Visual Studio 2017 Developer Command Prompt v15.9.11 >> [exec] ** Copyright (c) 2017 Microsoft Corporation >> [exec] >> ********************************************************************** >> [exec] [vcvarsall.bat] Environment initialized for: 'x64' >> [exec] ninja: Entering directory `out.gn/x64.release' >> [exec] [1/1] Regenerating ninja files >> [exec] FAILED: build.ninja >> [exec] ../../buildtools/win/gn.exe --root=../.. -q --check gen . >> [exec] ERROR at //BUILD.gn:3779:3: Assertion failed. >> [exec] assert(!v8_use_external_startup_data) >> [exec] ^----- >> [exec] ninja: error: rebuilding 'build.ninja': subcommand failed >> >> Is "v8_monolith" incompatible with "v8_use_snapshot"? How does one get >> around this problem? >> >> -- >> -- >> v8-users mailing list >> v8-users@googlegroups.com >> http://groups.google.com/group/v8-users >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to v8-users+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/v8-users/1ff68a3b-07c3-43f6-aaed-56a8001a7fe8%40googlegroups.com >> <https://groups.google.com/d/msgid/v8-users/1ff68a3b-07c3-43f6-aaed-56a8001a7fe8%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- > -- > v8-users mailing list > v8-users@googlegroups.com > http://groups.google.com/group/v8-users > --- > You received this message because you are subscribed to the Google Groups > "v8-users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-users+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-users/CAH3p7oPKpFHd7xBtmuoS6Pj_jhcXSVTBTCPMO-qnDhAsiE0trQ%40mail.gmail.com > <https://groups.google.com/d/msgid/v8-users/CAH3p7oPKpFHd7xBtmuoS6Pj_jhcXSVTBTCPMO-qnDhAsiE0trQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-users/CABexdQ4%2Biaf%2BgGX6F_paG6z%3DQ-AU588LM3yj-7RQS_dc%2BeOsJg%40mail.gmail.com.
