-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Chris and Mark,
On 2/28/20 11:51, Mark Thomas wrote: > On 28/02/2020 14:51, Chris Cheshire wrote: >> (9.0.31) >> >> What is the reason why the pattern isn't compiled with the case >> insensitive flag? Is it due to performance? > > I wrote that Valve. At least the first iteration anyway. Others > improved it along the way. > > I honestly can't remember why I opted for [bB]bot rather than > using CASE_INSENSITIVE. > > I do remember that the focus was on fixing an issue we (the ASF) > were having with our public Jira instance at the time in that bots > were generating huge numbers of sessions and, in turn, using up > large amounts of memory. > > Looking at it with the benefit of hindsight I'd worry about: - > performance - avoiding false positives > > There probably isn't much in it but I'd expect the current solution > is the right one for both of those. Unless you have a very > different UA pattern, in which case CASE_INSENSITIVE might help. > But I am guessing about the performance which really isn't the done > thing. > > If someone was to demonstrate that there was a measurable > performance benefit to some realistic patterns to using > CASE_INSENSITIVE then I'd support an enhancement to add an > attribute to specify the flags to use when compiling the pattern. You can always use the (?i) flag-enabler if you want to use case-insensitive matches without changing the code. - -chris -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl5ZUyAACgkQHPApP6U8 pFgAERAAtsF3fKvMs/nWMM+wEPBJPOs+81Sd+LoWkWaTc2dtxXlqmi+VVtK0HsOj RKO6WDVHD39Bzlf5PP8gi0Wjb9VgteyUl8A+Iz8TXC++iC2oUfQ8j3E3jX9zSWgV fxgrNmGtvJ4g6Rh+/sjLDjIBJ0dAyfJtYn3D+XpJgd1d9F/YNgHjXNWhHQ2pjG5j b0hVCcdvSHC+VMt7bGA1KdHFeVm6FqM6m8JVnPmlOBnAmOw0NSioMymEphvXiLfX 2Qy+RYe5J/LJwoJkYV5CYDuqLKBYci+t+vaOAfVt3a+RVs2aJGH86YbWjMLQ89o3 r5AC6K3RXMdKoyKRthwQ2/+uL9UoytFyikydImSREO+L9xpvaOruFZI8mSjeHHIt RwpbaOZntiCmzfaKEgBJNtnlcPg54VgW49RJ8WdUS0z2q3+nc9oJ3VB15bjUSgLb uH/0ak8GfjTyO8rnYgG1hXcQWby2iSdfMZvxNjU/SPL8qwN9UB3TIIfjTsoUAgcy xkbaGKkdh/ChMXles4QRVBNXUK1MFCWKhgfW2a8oHuBRmguk36ORJ1f6lO1gEz2j GVl7g8MhFTKcCx9DE8axd2Ywt6VPI5f/8RdTFGbJ/taO7p69YnoOD8fgqKzs1kcc 4oYtU1ZlN2y08wz9owkUuYFjUWT9spLkHX8tE3DwbkdZdo3QfUs= =s2f5 -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
