On 28/02/2020 14:51, Chris Cheshire wrote: > (9.0.31) > > What is the reason why the pattern isn't compiled with the case > insensitive flag? Is it due to performance?
I wrote that Valve. At least the first iteration anyway. Others improved it along the way. I honestly can't remember why I opted for [bB]bot rather than using CASE_INSENSITIVE. I do remember that the focus was on fixing an issue we (the ASF) were having with our public Jira instance at the time in that bots were generating huge numbers of sessions and, in turn, using up large amounts of memory. Looking at it with the benefit of hindsight I'd worry about: - performance - avoiding false positives There probably isn't much in it but I'd expect the current solution is the right one for both of those. Unless you have a very different UA pattern, in which case CASE_INSENSITIVE might help. But I am guessing about the performance which really isn't the done thing. If someone was to demonstrate that there was a measurable performance benefit to some realistic patterns to using CASE_INSENSITIVE then I'd support an enhancement to add an attribute to specify the flags to use when compiling the pattern. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
