Am 09.01.20 um 17:35 schrieb Chris Cheshire: > On Thu, Jan 9, 2020 at 11:15 AM Felix Schumacher > <felix.schumac...@internetallee.de> wrote: >> >> Am 09.01.20 um 17:01 schrieb Chris Cheshire: >>> Looking through the documentation for the rewrite valve [1], I see >>> there is an example of how to write and use a rewrite map to convert a >>> value to upper case. This is the inverse of what I want (lowercase), >>> so great, easy enough to implement. This seems like something that >>> could be included by default but I couldn't see anything in >>> catalina.jar. >>> >>> Is this something that would be included if I create a patch for it, >>> and how would I go about it? >> I have opened a PR a bit ago (https://github.com/apache/tomcat/pull/221) >> but hadn't had time to investigate any further. Remy thought it would be >> a bit overengineered. Romain liked the idea of ServiceLoader but wanted >> to have it a bit more optimized (see >> https://lists.apache.org/thread.html/472e875a46e811370f7df8b7d4fae37170a31d73c3d814a48e4d565c%40%3Cdev.tomcat.apache.org%3E). >> >> Would this be something you like to have? >> >> I think of committing the first part of the PR in any case, as I believe >> that the parsing of the parameters should be more in line with that of >> httpd. >> >> Felix >> > From the example in the docs > ** > RewriteMap uc example.maps.UpperCaseMap > RewriteRule ^/(.*)$ ${uc:$1} > ** > > All I would like is for UpperCaseMap to live within the Catalina > packaging as written so that I don't have to introduce a compile time > dependency for a configuration file entry. Maybe I am missing > something, but I don't see where having an SPI for this gains anything > for simple usages like this.
The idea was to include the maps that are included in the httpd implementation as documented at https://httpd.apache.org/docs/2.4/rewrite/rewritemap.html#int and at the same time to make it easier to include custom implementations via SPI. The good thing here is, that you showed interest int such implementations and that it is a nice feature indeed. Felix > > I can solve my problem by using multiple regular expressions, so it > isn't critical. It just seemed like something that could be included > by default. > > Chris > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > For additional commands, e-mail: users-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
