On Thu, Jan 9, 2020 at 5:16 PM Felix Schumacher < felix.schumac...@internetallee.de> wrote:
> > Am 09.01.20 um 17:01 schrieb Chris Cheshire: > > Looking through the documentation for the rewrite valve [1], I see > > there is an example of how to write and use a rewrite map to convert a > > value to upper case. This is the inverse of what I want (lowercase), > > so great, easy enough to implement. This seems like something that > > could be included by default but I couldn't see anything in > > catalina.jar. > > > > Is this something that would be included if I create a patch for it, > > and how would I go about it? > > I have opened a PR a bit ago (https://github.com/apache/tomcat/pull/221) > but hadn't had time to investigate any further. Remy thought it would be > a bit overengineered. Romain liked the idea of ServiceLoader but wanted > to have it a bit more optimized (see > > https://lists.apache.org/thread.html/472e875a46e811370f7df8b7d4fae37170a31d73c3d814a48e4d565c%40%3Cdev.tomcat.apache.org%3E > ). > > Would this be something you like to have? > > I think of committing the first part of the PR in any case, as I believe > that the parsing of the parameters should be more in line with that of > httpd. > I was planning to pull the non service loader parts of the PR as they are likely useful utility classes, but I didn't (procrastination ... and bad colds ...). I think I'm really against ServiceLoader configuration for Tomcat at the moment, it seems even worse than system properties overall. Rémy > > Felix > > > > > Chris > > > > [1] http://tomcat.apache.org/tomcat-9.0-doc/rewrite.html > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: users-h...@tomcat.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > For additional commands, e-mail: users-h...@tomcat.apache.org > >
