On Fri, Jan 5, 2018 at 8:38 AM, Rémy Maucherat <r...@apache.org> wrote:
> On Fri, Jan 5, 2018 at 12:25 AM, Michael Peng < > michael.p...@entrustdatacard.com> wrote: > >> Do the changes make sense, and what would be the side effect ? In our >> case, the "netInBuffer" could be full, i.e., postion = limit for large >> data. Maybe the "netInBuffer" should not be cleared since "compact" would >> reset the "netInBuffer", should it? >> >> The buffer is flipped after that and the NIO code is the same anyway, so > the change doesn't make sense indeed as is. > > Looking at it made it seem not right compared to NIO, so I made another change and hopefully fixed it. Rémy
