On Wed, Mar 3, 2010 at 8:24 AM, Massimo Lusetti <mluse...@gmail.com> wrote: > On Tue, Mar 2, 2010 at 11:39 PM, Howard Lewis Ship <hls...@gmail.com> wrote: > >> You may have to recode some of your custom >> ComponentClassTransformWorker. If you don't have one, show us the >> full stack trace so I can see what went wrong. >> >> You're seeing some imperfect backwards compatibility in the process of >> moving away from Javassist. What you used to accomplish (in 5.0 and >> 5.1) with Javassist scripting is now accomplished largely using >> ComponentMethodAdvice and some related techniques. The end result is >> quite nice. > > Did you have had possibility to measure performances before and after > this changes? > > I don't have any number by my side but a gut feeling of something more > slow then before... as i said is just a feeling about a very > "persistent" heavy application.
Haven't started performance analysis yet. In the long run, once Javassist is stripped out, I think we'll see real performance improvements from having ASM do the bytecode instead. However, the general approach of having field access delegate out to callbacks will have some more overhead than the inline bytecode approach (with Javassist). I don't think the difference will be significant, and what I'm seeing as I do more work is that we're making fewer changes to the loaded class than before. Let me expand on that. In the past, if a component needed to perform an operation that used an injected service (such as @Environmental and the Environment service), we'd have to inject a field with the Environment, and write the code (as Javassist script) that accesses the Environment via the injected field. By contrast, now the ComponentCallTransformWorker will have the Environment injected into it and will, in turn, inject inner class callbacks into the component. The component has no knowledge of the Environment service, just the callback associated with field access. > > Cheers > -- > Massimo > http://meridio.blogspot.com > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org > For additional commands, e-mail: users-h...@tapestry.apache.org > > -- Howard M. Lewis Ship Creator of Apache Tapestry The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast! (971) 678-5210 http://howardlewisship.com --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org For additional commands, e-mail: users-h...@tapestry.apache.org
