Den mån 14 okt. 2024 kl 13:07 skrev Franz Sirl < franz.sirl-ker...@lauterbach.com>:
> Hi, > > the attached patch fixes both issue 4856 and the (different) bug > we were seeing in one of our own repositories. > The problem boils down to the fact that with `svn log --xml --verbose` > a log-item is opened every time the PATH_CHANGE_RECEIVER callback is > used. But if the revision is later declared "unimportant", the > corresponding log-item closure is never sent via the REVISION_RECEIVER > callback. > > The patch fixes that by always using an intermediate callback routine > and recording the call of inner() in a new flag in > interesting_merge_baton_t. This flag is then used to decide if the > REVISION_RECEIVER callback has to be called to close the log-item. > > With yet another flag in interesting_merge_baton_t record_inner_call() > could be merged into interesting_merge() if you prefer that. > Thank you for the patch! In the discussion about issue 4177, Daniel Shahaf mentioned that there was an inconsistency about the number of times the receiver callback was called, so it seems likely you have found that issue. I'm going to test this further when time permits, hopefully this week. Kind regards, Daniel
