On Thu, 2013-01-10 at 19:49 -0500, Kevin A. McGrail wrote: > Do the scenarios you have identified cover all current usage of spamd? > The only use scenario I mentioned is entirely my own: I make no claims that anybody else uses spamc in the same way.
> Specifically things like MTAs that integrate spam checking especially > midstream and use these various exit levels? > Now for my suggested option changes: these were written on the assumption that, with the exception of the EX-TOOBIG kludge when -x is in force and which is now known to be undocumented, the spamc manpage is a true description of the effect of the various options. I haven't attempted to compare the current code with the current manpage. If there are discrepancies, then the code and manpage should be synchronised before 3.4.0 is released. That said, the manpage says there are only two ways in which exit codes are generated: -x --no-safe-fallback which should, were the kludge to be removed, output the complete set of exit codes and which will return the EX-TOOBIG code (98) -E --exitcode causes only two exit codes to be returned: 1 for spam and 0 for all other conditions. As a side effect, -c --check implies -E A further side effect, which I mis-described earlier, is that if the -x --no-safe-fallback option is in force, and the -d option's host resolves to multiple IPs, only the first address will be tried because -x prevents the fail-over from being tried. Another deficiency is that the manpage doesn't say whether -E or -x is the default though it is implied by the -x option description. > If we add flexibility that covers more scenarios, great but to me this > looks like you are talking about removing options that i can only > assume are used. Am i wrong? > With all due respect, yes. I'm suggesting that the default set of exit codes for all processing options should be what -E --exitcode currently defines and that -x (possibly renamed) overrides that just as it does at present. Taking this view makes the -E --exitcode option redundant and, indeed, confusing so its would be better to document this as the default set of exit codes and remove the -E --exitcode option. This does not constrain spamc flexibility or remove any current functionality. HTH Martin
