On Sat, 27 Jun 2009, Jeremy Morton wrote:

Why are you bothering with that? It seems unnecessarily complex. Here's my amended rule:

/\bwww\s?\W?\s?\w{3,6}\d{2,6}s?\W?\s?(?:c\s?o\s?m|n\s?e\s?t|o\s?r\s?g)\b/i

That would match wwwwhy11com, which may not be recognized by the mark as a URI they need to deobfuscate - do you really want it that loose?

That would match www.why11.com, which the regular URI processing would match - do you really want to match it twice?

That's why I posted a more-complex version.

Note that I'm not saying it's wrong, just that it's looser than I prefer.

--
 John Hardin KA7OHZ                    http://www.impsec.org/~jhardin/
 jhar...@impsec.org    FALaholic #11174     pgpk -a jhar...@impsec.org
 key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C  AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
  False is the idea of utility that sacrifices a thousand real
  advantages for one imaginary or trifling inconvenience; that would
  take fire from men because it burns, and water because one may drown
  in it; that has no remedy for evils except destruction. The laws
  that forbid the carrying of arms are laws of such a nature. They
  disarm only those who are neither inclined nor determined to commit
  crime.               -- Cesare Beccaria, quoted by Thomas Jefferson
-----------------------------------------------------------------------
 7 days until the 233rd anniversary of the Declaration of Independence

Reply via email to