Henrik Krohns wrote:
On Wed, Aug 08, 2007 at 10:51:05PM +0200, Michael Schaap wrote:
Hi John,
Thanks for maintaining this excellent plugin!
But I'm just wondering if ...
On 6-Aug-2007 04:39, John Rudd wrote:
-- changed complex dsl clientword to .*dsl.*
(too many variations of 'dsl' in hostnames, since it's word
bounded, the .*'s only match as far as the end of a word, so it's not
going to match _EVERYTHING_ under the sun, just every individual word with
dsl in it)
... isn't a bit too aggressive.
$ grep -i dsl /usr/share/dict/words
Someone might call their mail server "mudslinger", and they'd be treated as
a DSL client.
While that's unlikely, judging my small sample of logs the dsl string is
always in the front or end. So "[a-z]?dsl.*? .*?dsl" should work just as
fine. Maybe someone can grep a bigger log.
I had a very complex expression for it at some point, but I kept
noticing off variation, where "dsl" was in the middle of the word, or in
a few cases it was at the start of the word (dsla I think was the one I
saw). So I decided to just go to what I have now, instead of trying to
conceive of every possible variation.
