John Rudd wrote: > Question 1: Someone suggested that, for botnet_pass_domains, I not > re-invent the wheel. SA already has several whitelist options > (whitelist* and sare_whitelist* were specifically mentioned). They > suggested that I leverage them. My first (two part) question is:
Personally, I prefer to have a plugin be aböe to function independantly from other addons (such as sare whitelists). (I don't use ordinary whitelist commands in SA (when I whitelist something, I do it so that the filkter wiull not call SA at all).) Does the Botnet plugin really need any code at all to use the existing whitelists, or could this be done entirely with meta rules anyway? If it can be done with meta rules you could just put a few commented examples in Botnet.cf instead of having to expand the plugin. Or... You could make a separate file with contributed examples and include that in the Botnet package. This way there could be meta rules with DKIM, whitelists, p0f, ice cream, dark beer or whatever people send you without cluttering Botnet.cf and without ýou having to test and take responsibility for everything (just remember to put a disclaimer at the top if it). Or... You could just point out that meta rules are possible and let those who wants to read the SpamAssassin docs and make there own advanced rules. :-) Regards /Jonas -- Jonas Eckerman, FSDB & Fruktträdet http://whatever.frukt.org/ http://www.fsdb.org/ http://www.frukt.org/
