Re: all trusted when no received headers are found

[Matt Kettler]

Ben Wylie wrote:
> IS there a way to stop all trusted being triggered when no received
> headers are found at all?
>
> Thanks
> Ben
>
>

That should not happen in recent versions of SA.. What version are you on?

SA 3.1.x will only fire ALL_TRUSTED if all of the following are met:
    1) there is at LEAST one trusted relay
    2) there are NO untrusted relays
    3) there are NO unparseable Received: headers.

A message with no Received: headers would not match the first criteria.

Early members of the SA 3.0 series and the 2.6 series suffer from bugs
where only criteria 2 applies, causing false-positives on messages with
no Received: headers, or malformed Received: headers.

--------------------------------------------
Code that implements this, from EvalTests.pm of SA 3.1.0:

sub check_all_trusted {
  my ($self) = @_;
  return $self->{num_relays_trusted}
        && !$self->{num_relays_untrusted}
        && !$self->{num_relays_unparseable};
}


And the buggy version from 3.0.0:

sub check_all_trusted {
  my ($self) = @_;
  if ($self->{num_relays_untrusted} > 0) {
    return 0;
  } else {
    return 1;
  }

}