On Tue, Oct 11, 2022 at 02:54:08PM +0200, Damian wrote:
> > > # __SA4 injected inside amavis via $suppl_attrib->{rule_hits}
> > > meta SA4 __SA4
> > > score SA4 1
> > > describe SA4 dummy
> > yields
> > > SA dbg: rules-all: unrun dependencies prevented meta SA4 from
> > > running: __SA4
>
> The above is slightly misleading, even in SA3 one had to predeclare a
> default via
>
> > meta __SA4 0
> > meta SA4 __SA4
> > score SA4 1
> > describe SA4 dummy
>
> Such __SA4 default solves the "unrun dependencies prevented" issue, but
> still produces hits inconsistently.
Uggh.. I even use amavisd, but didn't notice that rule_hits stuff. This is
why we need and appreciate rc-testers. :-)
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8061
> Sometimes
>
> > SA dbg: check: tests=SA4
> > SA dbg: check: subtests=__SA4 (Total Subtest Hits: 1 / Deduplicated
> > Total Hits: 1)
> sometimes
> > SA dbg: check: tests=
> > SA dbg: check: subtests=__SA4 (Total Subtest Hits: 1 / Deduplicated
> > Total Hits: 1)
>
> As far as I can tell, the inconsistency comes from the unsorted key
> iteration in do_meta_tests() and finish_meta_tests().
The unsorted part doesn't matter, actually it's better this way so we able
to notice the problems. When meta handling for this case is fixed, it will
always work regardless..
