I'm counting this as three committer +1 :) Opened: KAFKA-1944 - Rename LogCleaner and related classes to LogCompactor <https://issues.apache.org/jira/browse/KAFKA-1944>
On Tue, Feb 10, 2015 at 4:31 PM, Guozhang Wang <wangg...@gmail.com> wrote: > +1 > > On Tue, Feb 10, 2015 at 2:23 PM, Joel Koshy <jjkosh...@gmail.com> wrote: > > > +1 > > > > On Tue, Feb 10, 2015 at 01:32:13PM -0800, Jay Kreps wrote: > > > I agree that would be a better name. We could rename it if everyone > likes > > > Compactor better. > > > > > > -Jay > > > > > > On Tue, Feb 10, 2015 at 9:33 AM, Gwen Shapira <gshap...@cloudera.com> > > wrote: > > > > > > > btw. the name LogCleaner is seriously misleading. Its more of a log > > > > compacter. > > > > Deleting old logs happens elsewhere from what I've seen. > > > > > > > > Gwen > > > > > > > > On Tue, Feb 10, 2015 at 8:07 AM, Jay Kreps <jay.kr...@gmail.com> > > wrote: > > > > > > > > > Probably you need to enable the log cleaner for those to show up? > We > > > > > disable it by default and so I think those metrics never get > created. > > > > > > > > > > -Jay > > > > > > > > > > On Tue, Feb 10, 2015 at 3:33 AM, o...@sematext.com < > > > > st.comm.c...@gmail.com > > > > > > > > > > > wrote: > > > > > > > > > > > Hello, > > > > > > > > > > > > I have a problem with some JMX metrics. In Kafka source code I > see > > > > > > LogCleaner (has metrics: 'max-buffer-utilization-percent', > > > > > > 'cleaner-recopy-percent', 'max-clean-time-secs') and > > LogCleanerManager > > > > > (has > > > > > > metric: 'max-dirty-percent') > > > > > > > > > > > > But I don't see this beans&metrics in jconsole when I attach to > > broker > > > > > > process. > > > > > > Any ideas why? Maybe this beans live only short time during > cleanup > > > > > that's > > > > > > why I don't see them in jconsole? > > > > > > > > > > > > I use Kafka monitoring tool which show me other metrics, but not > > these > > > > > > 'Log clean' metrics. > > > > > > > > > > > > Below are some SPM graphs showing the state of my system. > > > > > > Here's the 'Topic Bytes/Messages' graph: > > > > > > https://apps.sematext.com/spm-reports/s/omV6bYPGAG > > > > > > > > > > > > > > > > -- > -- Guozhang >
