Chris, Any update of the high level consumer example?
Also, in the Producer example, it would be useful to describe how to write a customized encoder. One subtle thing is that the encoder needs a constructor that takes a a single VerifiableProperties argument ( https://issues.apache.org/jira/browse/KAFKA-869). Thanks, Jun On Mon, Apr 22, 2013 at 10:40 AM, Chris Curtin <curtin.ch...@gmail.com>wrote: > Hi Jun, > > #1 and #2 are done, thanks for the code-review! > > I'll work on getting a High Level consumer example this week. I don't have > one readily usable (we quickly found the lack of control over offsets > didn't meet our needs) but I can get something this week. > > Congratulations on getting closer to Beta! > > Chris > > > On Mon, Apr 22, 2013 at 12:26 PM, Jun Rao <jun...@gmail.com> wrote: > > > Chris, > > > > Thanks for the wiki. We are getting close to releasing 0.8.0 beta and > your > > writeup is very helpful. The following are some comments for the 0.8 > > Producer wiki. > > > > 1. The following sentence is inaccurate. The producer will do random > > assignment as long as the key in KeyedMessage is null. If a key is not > > null, it will use the default partitioner if partitioner.class is not > set. > > By default if you don't include a partitioner.class Kafka will randomly > > assign the message to a partition. > > > > 2. In the following sentence, the first type is the key and the second > type > > is the message. > > The first is the type of the message, the second the type of the > Partition > > key. > > > > 3. Could you explain the "key.serializer.class" property too? > > > > In addition to the 0.8 SimpleConsumer wiki, could you write up one for > the > > 0.8 high level consumer? > > > > Thanks, > > > > Jun > > > > > > > > On Fri, Mar 29, 2013 at 8:28 AM, Chris Curtin <curtin.ch...@gmail.com > > >wrote: > > > > > Hi, > > > > > > I've added an example program for using a SimpleConsumer for 0.8.0. > Turns > > > out to be a little more complicated once you add Broker failover. I'm > not > > > 100% thrilled with how I detect and recover, so if someone has a better > > way > > > of doing this please let me (and this list) know. > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/0.8.0+SimpleConsumer+Example > > > > > > Thanks, > > > > > > Chris > > > > > > > > > On Mon, Mar 25, 2013 at 8:02 AM, Chris Curtin <curtin.ch...@gmail.com > > > >wrote: > > > > > > > > > > > Hi David, > > > > > > > > Thanks for the feedback. I've seen the example before and after in > > > > different books/articles and it doesn't matter to me. > > > > > > > > Anyone else want to help define a style guide or is there one I > didn't > > > see > > > > already? > > > > > > > > Thanks, > > > > > > > > Chris > > > > > > > > > > > > On Thu, Mar 21, 2013 at 7:46 PM, David Arthur <mum...@gmail.com> > > wrote: > > > > > > > >> This looks great! A few comments > > > >> > > > >> * I think it would be useful to start with a complete example (ready > > to > > > >> copy/paste) and then break it down bit by bit > > > >> * Some of the formatting is funky (gratuitous newlines), also I > think > > 2 > > > >> spaces looks nicer than 4 > > > >> * In the text, it might be useful to embolden or italicize class > names > > > >> > > > >> Also, maybe we should move this to a separate thread? > > > >> > > > > > > > > > > > > > >
