This kind of distributed tracing seems almost like logging frameworks where eventually a facade like slf4j was developed to support all the different individual frameworks.
In any event, I definitely think it's best at this point simply for the broker to expose hooks (e.g. ActiveMQServerPlugin) rather than integrate a particular solution (as Michael has already suggested). I also think the code should be hosted in a separate repository so it can have its own release cycle, etc. The broker documentation could certainly have a chapter on distributed tracing which links to the other repo, though. As far as the broker goes, the goal here should be improving the ActiveMQServerPlugin so that all the hooks are present to support distributed tracing well. I believe some PRs have already been sent for this. Justin On Mon, Aug 20, 2018 at 11:59 AM, michael.andre.pearce < michael.andre.pea...@me.com.invalid> wrote: > Add to that list (as i said there's always more) > > https://cloud.spring.io/spring-cloud-sleuth/ > > > > Sent from my Samsung Galaxy smartphone. > -------- Original message --------From: "michael.andre.pearce" < > michael.andre.pea...@me.com.INVALID> Date: 20/08/2018 17:35 (GMT+00:00) > To: users@activemq.apache.org Subject: Re: AW: AW: [DISCUSS] OpenTracing > in Artemis > Btw similar initiatives, which all could be requesting similar stating the > same argument. > > https://opencensus.iohttps://micrometer.iohttps://openmetrics.io > I dont think it be suitable to natively support all of these (and im sure > there is more) within the core product, thus why the plugins exist so > people can add and maintain the support, without needing changes in the > core broker. > > Sent from my Samsung Galaxy smartphone. > -------- Original message --------From: "michael.andre.pearce" < > michael.andre.pea...@me.com> Date: 20/08/2018 16:37 (GMT+00:00) To: > users@activemq.apache.org Subject: Re: AW: AW: [DISCUSS] OpenTracing in > Artemis > Whilst appreciate that open tracing project intent is that it becomes the > standard, afaik there is just two main project adopting it zipkin and > jaeger. > Currently none of the big APM vendors some i mentioned in previous are > backing it. As such they could form create their standard and then come > with the same request. So in my mind its not an established api that had > critical mass to the level like jms or jmx is just yet. And i would be wary > of adding it at this time. > As noted by the original email the current plugins expose a good amount to > be able to create such a plugin. > Lastly this can live as i said earlier within open tracing contribs > project, it can then benefit from its own release cycle. > Also there was a decision a while back to keep integrations to artemis > plugins level, and for them not to be part of the broker for similar > arguements. I for one wanted to add a kafka integration in, but same > reasons its ended up having its own project else where. > > > > > > Sent from my Samsung Galaxy smartphone. >
