I did not include unit tests in my patch. I think many people did not run into this issue because many Cassandra clients handle the DateType when found as a CUSTOM type.
-Karl > On Jul 21, 2014, at 8:26 PM, Robert Coli <rc...@eventbrite.com> wrote: > >> On Mon, Jul 21, 2014 at 1:58 AM, Ben Hood <0x6e6...@gmail.com> wrote: >> On Sat, Jul 19, 2014 at 7:35 PM, Karl Rieb <karl.r...@gmail.com> wrote: >> > Can now be followed at: >> > https://issues.apache.org/jira/browse/CASSANDRA-7576. >> >> Nice work! Finally we have a proper solution to this issue, so well done to >> you. > > For reference, I consider this issue of sufficient severity to recommend > against upgrading to any version of 2.0 before 2.0.10, unless you are certain > you have no such schema. > > I'm pretty sure reversed comparator timestamps are a common type of schema, > given that there are blog posts recommending their use, so I struggle to > understand how this was not detected by unit tests. > > Does your fix add unit tests which would catch this case on upgrade? > > =Rob >
