Hi Simon, Thanks again for your review. Here are my responses:
> The changelog initially looks okay; I'd add a "." at the end of your entry, but Version Numbers Are Cheap, so I fully understand why you have the ppa0 revision there. Final version should probably be "1.0.25-0ubuntu1". I never know which version number I should use for my PPA. I know it will be on 1.0.25-0ubuntu1 for the first uploaded version. > Ah okay, looking at the control file, that's why there's another orig file; it's vendoring, plus this uses dh-cargo. While I don't particularly enjoy the idea of vendoring this many packages, and would encourage you to switch to as many archive-based dependencies as possible, I understand that it may be difficult. Indeed, moreover I am planning to ask for an SRU exception for this package and I imagine it will be easier to SRU if all the dependencies are vendored. > `Standards-Version: 4.6.1` is outdated, that should be 4.7.0 at the very minimum. Please fix this. Fixed > Additionally, while I would encourage you to get this into Debian as well, you don't need this line until that point (and since your email ends in canonical.com, you can probably just set yourself as the maintainer): `XSBC-Original-Maintainer: Gauthier Jolly <gauthier.jo...@canonical.com>` Fixed > `debian/my-rules-que-me-gusta` seems like an accident, what does it do? Indeed, removed. ## rules file and building > Some of the lines in your rules file are quite long, could you please wrap them? Done > Much of this is redundant/no longer necessary with modern debhelper, and > could probably just be removed to .install file lines: > ... Done > The same goes with the `dh_auto_test` stanza, most of that (probably not all of it, you'll probably still need to wrap it in that `nocheck` check) can probably be moved to `debian/tests/control`. Here I don't really understand, I moved the tests to `d/tests` but I don't think it's a good idea because then `dh_auto_test` doesn't run them anymore. Can you be more specific? > Lintian had a lot to say, though: > As you can see, there's a lot of potential for improvement here. Please fix > as much as you can from that list, and override the false positives. Done. Running ``` lintian --info --display-info --pedantic --display-experimental ``` doesn't return any message. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2098393 Title: [needs-packaging] azure-proxy-agent To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2098393/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
