Hey, Gauthier! Thank you so much for working on this!
The following is a full review of your package for inclusion into
Ubuntu. It's fairly verbose, but should hopefully clarify any questions
you may currently have about the process.
This is all off the top of my head; if there's an actual reference I
should be using, let me know! It's also Markdown-formatted.
## Initial Impressions
Firstly, I inspected the artifacts in the PPA:
Package files
- azure-proxy-agent_1.0.25-0ppa2.debian.tar.xz (10.4 KiB)
- azure-proxy-agent_1.0.25-0ppa2.dsc (3.7 KiB)
- azure-proxy-agent_1.0.25-0ppa2_amd64.deb (2.0 MiB)
- azure-proxy-agent_1.0.25-0ppa2_arm64.deb (1.9 MiB)
- azure-proxy-agent_1.0.25.orig-rust-vendor.tar.xz (5.7 MiB)
- azure-proxy-agent_1.0.25.orig.tar.xz (274.9 KiB)
And downloaded the files via `dget -u`. It initially strikes me as
interesting that there are two orig tarballs here.
This is a `3.0 (quilt)` source package written in Rust, with no Quilt
patches currently added. A test of the watch file proves that it works.
It may be worth looking into some sort of verification, although this
isn't mandatory.
The changelog initially looks okay; I'd add a "." at the end of your
entry, but Version Numbers Are Cheap, so I fully understand why you have
the ppa0 revision there. Final version should probably be
"1.0.25-0ubuntu1".
Ah okay, looking at the control file, that's why there's another orig
file; it's vendoring, plus this uses dh-cargo. While I don't
particularly enjoy the idea of vendoring this many packages, and would
encourage you to switch to as many archive-based dependencies as
possible, I understand that it may be difficult.
`Standards-Version: 4.6.1` is outdated, that should be 4.7.0 at the very
minimum. Please fix this.
Additionally, while I would encourage you to get this into Debian as
well, you don't need this line until that point (and since your email
ends in canonical.com, you can probably just set yourself as the
maintainer): `XSBC-Original-Maintainer: Gauthier Jolly
<gauthier.jo...@canonical.com>`
`debian/my-rules-que-me-gusta` seems like an accident, what does it do?
## rules file and building
Some of the lines in your rules file are quite long, could you please
wrap them?
Much of this is redundant/no longer necessary with modern debhelper, and
could probably just be removed to .install file lines:
```
execute_after_dh_auto_install: TARGET=debian/azure-proxy-agent
execute_after_dh_auto_install:
install -m0755 target/release/azure-proxy-agent \
$(TARGET)/usr/sbin
install -m0644 debian/proxy-agent.json \
$(TARGET)/etc/azure/proxy-agent.json
install -m0644 proxy_agent_setup/src/linux/azure-proxy-agent.service \
debian/azure-proxy-agent.service
dh_installsystemd
```
The same goes with the `dh_auto_test` stanza, most of that (probably not
all of it, you'll probably still need to wrap it in that `nocheck`
check) can probably be moved to `debian/tests/control`.
Okay, I'm building your package with the following command: `sbuild -c
plucky-amd64-shm -j12 --no-clean-source`
The build passes and produces the following files, which seem to look
good on a brief, initial glance:
drwxr-xr-x root/root 0 2025-02-13 10:20 ./
drwxr-xr-x root/root 0 2025-02-13 10:20 ./etc/
drwxr-xr-x root/root 0 2025-02-13 10:20 ./etc/azure/
-rw-r--r-- root/root 453 2025-02-13 10:20 ./etc/azure/proxy-agent.json
drwxr-xr-x root/root 0 2025-02-13 10:20 ./usr/
drwxr-xr-x root/root 0 2025-02-13 10:20 ./usr/lib/
drwxr-xr-x root/root 0 2025-02-13 10:20 ./usr/lib/azure-proxy-agent/
-rw-r--r-- root/root 28528 2025-02-13 10:20
./usr/lib/azure-proxy-agent/ebpf_cgroup.o
drwxr-xr-x root/root 0 2025-02-13 10:20 ./usr/lib/systemd/
drwxr-xr-x root/root 0 2025-02-13 10:20 ./usr/lib/systemd/system/
-rw-r--r-- root/root 271 2025-02-13 10:20
./usr/lib/systemd/system/azure-proxy-agent.service
drwxr-xr-x root/root 0 2025-02-13 10:20 ./usr/sbin/
-rwxr-xr-x root/root 7147608 2025-02-13 10:20 ./usr/sbin/azure-proxy-agent
drwxr-xr-x root/root 0 2025-02-13 10:20 ./usr/share/
drwxr-xr-x root/root 0 2025-02-13 10:20 ./usr/share/doc/
drwxr-xr-x root/root 0 2025-02-13 10:20
./usr/share/doc/azure-proxy-agent/
-rw-r--r-- root/root 173 2025-02-13 10:20
./usr/share/doc/azure-proxy-agent/changelog.Debian.gz
-rw-r--r-- root/root 23679 2025-02-13 10:20
./usr/share/doc/azure-proxy-agent/copyright
drwxr-xr-x root/root 0 2025-02-13 10:20 ./usr/share/lintian/
drwxr-xr-x root/root 0 2025-02-13 10:20 ./usr/share/lintian/overrides/
-rw-r--r-- root/root 50 2025-02-13 10:20
./usr/share/lintian/overrides/azure-proxy-agent
drwxr-xr-x root/root 0 2025-02-13 10:20 ./usr/share/man/
drwxr-xr-x root/root 0 2025-02-13 10:20 ./usr/share/man/man8/
-rw-r--r-- root/root 849 2025-02-13 10:20
./usr/share/man/man8/azure-proxy-agent.8.gz
Lintian had a lot to say, though:
W: azure-proxy-agent source: bad-exception-format-in-dep5-copyright apache-2.0
with llvm-exception [debian/copyright:538]
N:
N: The “License” field contains a short name with a bad exception format.
N: According to specification format of exception is: shortlicencename with
N: exceptionname exception.
N:
N: If more than one exception applies to a single license, an arbitrary short
N: name must be used instead.
N:
N: Please refer to
N: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
N: details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debian/copyright/dep5
N:
N:
W: azure-proxy-agent source: missing-license-paragraph-in-dep5-copyright
apache-2.0 with llvm-exception [debian/copyright:538]
N:
N: The Files paragraph in the machine readable copyright file references a
N: license for which no stand-alone License paragraph exists.
N:
N: Sometimes this tag appears because of incorrect ordering. Stand-alone
N: License paragraphs must appear *after* all Files paragraphs.
N:
N: Please refer to
N: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ and
N: Bug#959067 for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: debian/copyright/dep5
N:
N:
W: azure-proxy-agent source: missing-license-paragraph-in-dep5-copyright
bsl-1.0 [debian/copyright:394]
N:
W: azure-proxy-agent source: missing-license-paragraph-in-dep5-copyright
unlicense [debian/copyright:278]
N:
W: azure-proxy-agent: systemd-service-file-refers-to-unusual-wantedby-target
network.target [usr/lib/systemd/system/azure-proxy-agent.service]
N:
N: The specified systemd service file declares an unusual WantedBy=
N: relationship.
N:
N: Most services that want to be started automatically at boot should use
N: WantedBy=multi-user.target or WantedBy=graphical.target. Services that
N: want to be started in rescue or single-user mode should instead use
N: WantedBy=sysinit.target
N:
N: Please refer to https://wiki.debian.org/Teams/pkg-systemd/rcSMigration for
N: details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: systemd
N:
N:
W: azure-proxy-agent source: unknown-field Vendored-Sources-Rust
N:
N: See the Policy Manual for a list of the possible fields in a package
N: control files.
N:
N: Please refer to Binary package control files – DEBIAN/control (Section
N: 5.3) in the Debian Policy Manual and Debian source control files – .dsc
N: (Section 5.4) in the Debian Policy Manual for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: fields/unknown
N: Renamed from: unknown-field-in-dsc unknown-field-in-control
N:
N:
I: azure-proxy-agent source: adopted-extended-field (in section for
azure-proxy-agent) XB-X-Cargo-Built-Using [debian/control:37]
N:
N: A field in debian/control has an extension prefix but is also known
N: without it.
N:
N: Extension prefixes like XS-* or XC-* allow experimental fields to
N: propagate to the right place when packages are built with dpkg. In this
N: case, however, the field is also known without the prefix. In all
N: likelihood the field was permanently adopted, and dpkg learned how to deal
N: with it.
N:
N: Please consider removing the extension prefix for the field name.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/control/field/adopted
N: Renamed from: xc-package-type-in-debian-control
N: xs-testsuite-field-in-debian-control xs-vcs-field-in-debian-control
N:
N:
I: azure-proxy-agent: file-references-package-build-path
[usr/lib/azure-proxy-agent/ebpf_cgroup.o]
N:
N: The listed file or maintainer script appears to reference the build path
N: used to build the package as specified in the Build-Path field of the
N: .buildinfo file.
N:
N: This is likely to cause the package to be unreproducible, but it may also
N: indicate that the package will not work correctly outside of the
N: maintainer's own system.
N:
N: Please note that this tag will not appear unless the .buildinfo file
N: contains a Build-Path field. That field is optional. You may have to set
N: DEB_BUILD_OPTIONS=buildinfo=+path or use
N: --buildinfo-option=--always-include-path with dpkg-buildpackage when
N: building.
N:
N: Please refer to https://reproducible-builds.org/,
N: https://wiki.debian.org/ReproducibleBuilds/BuildinfoFiles, and the
N: dpkg-genbuildinfo(1) manual page for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: files/contents
I: azure-proxy-agent: file-references-package-build-path
[usr/sbin/azure-proxy-agent]
I: azure-proxy-agent: hardening-no-fortify-functions
[usr/sbin/azure-proxy-agent]
N:
N: This package provides an ELF binary that lacks the use of fortified libc
N: functions. Either there are no potentially unfortified functions called by
N: any routines, all unfortified calls have already been fully validated at
N: compile-time, or the package was not built with the default Debian
N: compiler flags defined by dpkg-buildflags. If built using dpkg-buildflags
N: directly, be sure to import CPPFLAGS.
N:
N: NB: Due to false-positives, Lintian ignores some unprotected functions
N: (e.g. memcpy).
N:
N: Please refer to https://wiki.debian.org/Hardening and Bug#673112 for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/hardening
I: azure-proxy-agent source: out-of-date-standards-version 4.6.1 (released
2022-05-11) (current is 4.7.0)
N:
N: The source package refers to a Standards-Version older than the one that
N: was current at the time the package was created (according to the
N: timestamp of the latest debian/changelog entry). Please consider updating
N: the package to current Policy and setting this control field
N: appropriately.
N:
N: If the package is already compliant with the current standards, you don't
N: have to re-upload the package just to adjust the Standards-Version control
N: field. However, please remember to update this field next time you upload
N: the package.
N:
N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the
N: debian-policy package for a summary of changes in newer versions of
N: Policy.
N:
N: Please refer to
N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/standards-version
I: azure-proxy-agent: spelling-error-in-binary nonexistant nonexistent
[usr/sbin/azure-proxy-agent]
N:
N: Lintian found a spelling error in the given binary. Lintian has a list of
N: common misspellings that it looks for. It does not have a dictionary like
N: a spelling checker does.
N:
N: If the string containing the spelling error is translated with the help of
N: gettext or a similar tool, please fix the error in the translations as
N: well as the English text to avoid making the translations fuzzy. With
N: gettext, for example, this means you should also fix the spelling mistake
N: in the corresponding msgids in the *.po files.
N:
N: You can often find the word in the source code by running:
N:
N: grep -rw <word> <source-tree>
N:
N: This tag may produce false positives for words that contain non-ASCII
N: characters due to limitations in strings.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/spelling
I: azure-proxy-agent: spelling-error-in-binary wHE when
[usr/sbin/azure-proxy-agent]
I: azure-proxy-agent: spelling-error-in-binary wTH with
[usr/sbin/azure-proxy-agent]
I: azure-proxy-agent: systemd-service-file-missing-documentation-key
[usr/lib/systemd/system/azure-proxy-agent.service]
N:
N: The systemd service file does not contain a Documentation key.
N:
N: Documentation for systemd service files can be automatically viewed using
N: systemctl help servicename if this field is present.
N:
N: Please refer to the systemd.unit(5) manual page for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: systemd
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/hdrhistogram/tests/data/seq-nums.hist
[debian/source/include-binaries:1]
N:
N: An entry in debian/source/include-binaries does not exist in the patched
N: source tree. Please remove the entry.
N:
N: The format for the file is described in the manual page for dpkg-source.
N:
N: Please refer to the dpkg-source(1) manual page, Bug#528001, and
N: https://stackoverflow.com/questions/21057015/debian-include-binaries-format
N: for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/source/include-binaries
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/hdrhistogram/tests/data/seq-nums.histz
[debian/source/include-binaries:2]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_dense_crash-9486fb7c8a93b12c12a62166b43d31640c0208a9
[debian/source/include-binaries:3]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_dense_minimized-from-9486fb7c8a93b12c12a62166b43d31640c0208a9
[debian/source/include-binaries:4]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_sparse_crash-0da59c0434eaf35e5a6b470fa9244bb79c72b000
[debian/source/include-binaries:5]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_sparse_crash-18cfc246f2ddfc3dfc92b0c7893178c7cf65efa9
[debian/source/include-binaries:6]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_sparse_crash-61fd8e3003bf9d99f6c1e5a8488727eefd234b98
[debian/source/include-binaries:7]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_sparse_crash-a1b839d899ced76d5d7d0f78f9edb7a421505838
[debian/source/include-binaries:8]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_sparse_crash-c383ae07ec5e191422eadc492117439011816570
[debian/source/include-binaries:9]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_sparse_crash-d07703ceb94b10dcd9e4acb809f2051420449e2b
[debian/source/include-binaries:10]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_sparse_crash-dbb8172d3984e7e7d03f4b5f8bb86ecd1460eff9
[debian/source/include-binaries:11]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex-automata/tests/gen/dense/multi_pattern_v2_fwd.bigendian.dfa
[debian/source/include-binaries:12]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex-automata/tests/gen/dense/multi_pattern_v2_fwd.littleendian.dfa
[debian/source/include-binaries:13]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex-automata/tests/gen/dense/multi_pattern_v2_rev.bigendian.dfa
[debian/source/include-binaries:14]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex-automata/tests/gen/dense/multi_pattern_v2_rev.littleendian.dfa
[debian/source/include-binaries:15]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex-automata/tests/gen/sparse/multi_pattern_v2_fwd.bigendian.dfa
[debian/source/include-binaries:16]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex-automata/tests/gen/sparse/multi_pattern_v2_fwd.littleendian.dfa
[debian/source/include-binaries:17]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex-automata/tests/gen/sparse/multi_pattern_v2_rev.bigendian.dfa
[debian/source/include-binaries:18]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex-automata/tests/gen/sparse/multi_pattern_v2_rev.littleendian.dfa
[debian/source/include-binaries:19]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex/tests/fuzz/testdata/crash-7eb3351f0965e5d6c1cb98aa8585949ef96531ff
[debian/source/include-binaries:20]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex/tests/fuzz/testdata/crash-8760b19b25d74e3603d4c643e9c7404fdd3631f9
[debian/source/include-binaries:21]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex/tests/fuzz/testdata/crash-cd33b13df59ea9d74503986f9d32a270dd43cc04
[debian/source/include-binaries:22]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex/tests/fuzz/testdata/minimized-from-8760b19b25d74e3603d4c643e9c7404fdd3631f9
[debian/source/include-binaries:23]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex/tests/fuzz/testdata/slow-unit-3ab758ea520027fefd3f00e1384d9aeef155739e
[debian/source/include-binaries:24]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex/tests/fuzz/testdata/slow-unit-5345fccadf3812c53c3ccc7af5aa2741b7b2106c
[debian/source/include-binaries:25]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex/tests/fuzz/testdata/slow-unit-6bd643eec330166e4ada91da2d3f284268481085
[debian/source/include-binaries:26]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex/tests/fuzz/testdata/slow-unit-93c73a43581f205f9aaffd9c17e52b34b17becd0
[debian/source/include-binaries:27]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex/tests/fuzz/testdata/slow-unit-9ca9cc9929fee1fcbb847a78384effb8b98ea18a
[debian/source/include-binaries:28]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/regex/tests/fuzz/testdata/slow-unit-b8a052f4254802edbe5f569b6ce6e9b6c927e9d6
[debian/source/include-binaries:29]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/unicode-ident/tests/fst/xid_continue.fst
[debian/source/include-binaries:30]
I: azure-proxy-agent source: unused-entry-in-debian-source-include-binaries
debian/rust-vendor/unicode-ident/tests/fst/xid_start.fst
[debian/source/include-binaries:31]
P: azure-proxy-agent source: maintainer-manual-page [debian/azure-proxy-agent.8]
N:
N: The maintainer keeps a manual page in ./debian. Please forward the manual
N: page upstream and ask them to include in their version control system, and
N: in their next release.
N:
N: If the manual page was already forwarded or rejected, or the upstream is
N: gone, please override the tag and annotate it with a suitable comment.
N:
N: Please refer to social contract item 2, Coordination with upstream
N: developers (Section 3.1.4) in the Debian Developer's Reference, and
N: Changes to the upstream sources (Section 4.3) in the Debian Policy Manual
N: for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/manual-pages
N: Renamed from: maintainer-manpage
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/anstream/examples/]
N:
N: The original source tarball contains the specified examples directory.
N: However, no examples are installed in any binary packages.
N:
N: Please use dh_installexamples to install these to the most relevant
N: package, for example by adding the directory name followed by a wildcard
N: to a debian/pkgname.examples file.
N:
N: Lintian looks for any directory called examples under /usr/share/doc in
N: all binary packages.
N:
N: Please refer to the dh_installexamples(1) manual page for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: examples
N:
N: Screen: examples/in-tests
N: Advocates: "Scott Kitterman" <deb...@kitterman.com>
N: Reason:
N: Some sources like python-tomlkit trigger this tag for tests
because of files
N: in ./tests/examples/. They are not examples for tomlkit,
however. They are
N: examples of TOML files used in the tests.
N:
N: Overall, the check is probably better off not looking in test
N: directories.
N:
N: Read more in Bug#1005184.
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/anstyle-parse/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/anstyle-query/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/anstyle/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/autocfg/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/bitflags/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/clap/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/crossbeam-epoch/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/hdrhistogram/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/hyper-util/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/itertools/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/mio/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/once_cell/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/os_info/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/pin-project/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/ryu/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/sysinfo-0.28.4/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/sysinfo/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/tower/examples/]
P: azure-proxy-agent source: package-does-not-install-examples
[rust-vendor/uzers/examples/]
X: azure-proxy-agent source: debian-watch-does-not-check-openpgp-signature
[debian/watch]
N:
N: This watch file does not specify a means to verify the upstream tarball
N: using a cryptographic signature.
N:
N: If upstream distributions provides such signatures, please use the
N: pgpsigurlmangle options in this watch file's opts= to generate the URL of
N: an upstream OpenPGP signature. This signature is automatically downloaded
N: and verified against a keyring stored in debian/upstream/signing-key.asc
N:
N: Of course, not all upstreams provide such signatures but you could request
N: them as a way of verifying that no third party has modified the code after
N: its release (projects such as phpmyadmin, unrealircd, and proftpd have
N: suffered from this kind of attack).
N:
N: Please refer to the uscan(1) manual page for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/watch
N: Renamed from: debian-watch-does-not-check-gpg-signature
N: debian-watch-may-check-gpg-signature
N: This tag is experimental.
X: azure-proxy-agent source: prefer-uscan-symlink filenamemangle
s/.*?(\d[\d\.-]*@ARCHIVE_EXT@)/@PACKAGE@-$1/ [debian/watch:4]
N:
N: Please consider setting USCAN_SYMLINK=rename in your ~/.devscripts
N: configuration file instead of using the option filenamemangle in
N: debian/watch.
N:
N: Please check with your team before making changes to sources you maintain
N: together. There are circumstances when the filenamemangle option is
N: better.
N:
N: Please refer to the uscan(1) manual page for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/watch
N: This tag is experimental.
X: azure-proxy-agent: systemd-service-file-missing-hardening-features
[usr/lib/systemd/system/azure-proxy-agent.service]
N:
N: The specified systemd .service file does not appear to enable any
N: hardening options.
N:
N: systemd has support for many security-oriented features such as isolating
N: services from the network, private /tmp directories, as well as control
N: over making directories appear read-only or even inaccessible, etc.
N:
N: Please consider supporting some options, collaborating upstream where
N: necessary about any potential changes.
N:
N: Please refer to the systemd.service(5) manual page and
N: http://0pointer.de/blog/projects/security.html for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: systemd
N: This tag is experimental.
X: azure-proxy-agent source: upstream-metadata-file-is-missing
N:
N: This source package is not Debian-native but it does not have a
N: debian/upstream/metadata file.
N:
N: The Upstream MEtadata GAthered with YAml (UMEGAYA) project is an effort to
N: collect meta-information about upstream projects from any source package.
N: This file is in YAML format and it is used in to feed the data in the
N: UltimateDebianDatabase. For example, it can contains the way the authors
N: want their software be cited in publications and some bibliographic
N: references about the software.
N:
N: Please add a debian/upstream/metadata file.
N:
N: Please refer to https://dep-team.pages.debian.net/deps/dep12/ and
N: https://wiki.debian.org/UpstreamMetadata for details.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/upstream/metadata
N: This tag is experimental.
X: azure-proxy-agent source: very-long-line-length-in-source-file 10953 > 512
[rust-vendor/regex-automata/tests/gen/dense/multi_pattern_v2_fwd.bigendian.dfa:27]
N:
N: The source file includes a line length that is well beyond the normally
N: human made code line length.
N:
N: This very long line length does not allow Lintian to do correctly some
N: source file checks.
N:
N: This line could also be the result of some text injected by a computer
N: program, and thus could lead to FTBFS bugs.
N:
N: Last but not least, long line in source code could be used to obfuscate
N: the source code and to hide stuff like backdoors or security problems.
N:
N: It could be due to jslint source comments or other build tool comments.
N:
N: You may report this issue upstream.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: files/contents/line-length
N: Renamed from: insane-line-length-in-source-file
N: This tag is experimental.
N:
N: Screen: autotools/long-lines
N: Advocates: "Russ Allbery" <r...@debian.org>
N: Reason:
N: Upstream sources using autoconf have traditionally been
N: distributed with generated ./configure scripts as well as
N: other third-party m4 macro files such as libtool.
N:
N: When paired with automake, there may also be some intermediate
N: Makefile.in files.
N:
N: A lot of sources potentially contain such files, but they are
N: not actionable by either the Debian distributor or by the
N: upstream maintainer.
N:
N: As a side note, modern Debian build protocols will re-create
N: many of those files via dh_autoreconf. They are present merely
N: to aid in bootstrapping systems where the GNU suite may not yet
N: be available.
N:
N: Read more in Bug#996740.
X: azure-proxy-agent source: very-long-line-length-in-source-file 10953 > 512
[rust-vendor/regex-automata/tests/gen/dense/multi_pattern_v2_fwd.littleendian.dfa:27]
X: azure-proxy-agent source: very-long-line-length-in-source-file 1141 > 512
[rust-vendor/serde_json/tests/lexical/parse.rs:169]
X: azure-proxy-agent source: very-long-line-length-in-source-file 1545 > 512
[rust-vendor/anstyle-parse/src/state/table.rs:359]
X: azure-proxy-agent source: very-long-line-length-in-source-file 1882 > 512
[rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_dense_minimized-from-9486fb7c8a93b12c12a62166b43d31640c0208a9:1]
X: azure-proxy-agent source: very-long-line-length-in-source-file 1894 > 512
[rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_dense_crash-9486fb7c8a93b12c12a62166b43d31640c0208a9:1]
X: azure-proxy-agent source: very-long-line-length-in-source-file 1988 > 512
[doc/GPA Arch Diagram.vsdx:125]
X: azure-proxy-agent source: very-long-line-length-in-source-file 2088 > 512
[debian/control:18]
X: azure-proxy-agent source: very-long-line-length-in-source-file 516 > 512
[e2etest/GuestProxyAgentTest/LinuxScripts/GuestProxyAgentExtensionValidation.sh:160]
X: azure-proxy-agent source: very-long-line-length-in-source-file 543 > 512
[rust-vendor/regex-automata/tests/gen/sparse/multi_pattern_v2_rev.bigendian.dfa:43]
X: azure-proxy-agent source: very-long-line-length-in-source-file 543 > 512
[rust-vendor/regex-automata/tests/gen/sparse/multi_pattern_v2_rev.littleendian.dfa:43]
X: azure-proxy-agent source: very-long-line-length-in-source-file 567 > 512
[rust-vendor/clap/src/_faq.rs:49]
X: azure-proxy-agent source: very-long-line-length-in-source-file 615 > 512
[rust-vendor/cfg_aliases/README.md:88]
X: azure-proxy-agent source: very-long-line-length-in-source-file 619 > 512
[rust-vendor/cfg_aliases/src/lib.rs:88]
X: azure-proxy-agent source: very-long-line-length-in-source-file 685 > 512
[rust-vendor/itertools/CHANGELOG.md:128]
X: azure-proxy-agent source: very-long-line-length-in-source-file 7218 > 512
[rust-vendor/regex-automata/tests/gen/dense/multi_pattern_v2_rev.littleendian.dfa:27]
X: azure-proxy-agent source: very-long-line-length-in-source-file 7221 > 512
[rust-vendor/regex-automata/tests/gen/dense/multi_pattern_v2_rev.bigendian.dfa:27]
X: azure-proxy-agent source: very-long-line-length-in-source-file 728 > 512
[rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_sparse_crash-dbb8172d3984e7e7d03f4b5f8bb86ecd1460eff9:1]
X: azure-proxy-agent source: very-long-line-length-in-source-file 776 > 512
[rust-vendor/regex-syntax/src/hir/translate.rs:3720]
X: azure-proxy-agent source: very-long-line-length-in-source-file 778 > 512
[rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_sparse_crash-c383ae07ec5e191422eadc492117439011816570:2]
X: azure-proxy-agent source: very-long-line-length-in-source-file 796 > 512
[rust-vendor/unicode-ident/tests/fst/xid_continue.fst:180]
X: azure-proxy-agent source: very-long-line-length-in-source-file 802 > 512
[rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_sparse_crash-a1b839d899ced76d5d7d0f78f9edb7a421505838:1]
X: azure-proxy-agent source: very-long-line-length-in-source-file 8285 > 512
[rust-vendor/hdrhistogram/tests/data/seq-nums.hist:1]
X: azure-proxy-agent source: very-long-line-length-in-source-file 832 > 512
[rust-vendor/unicode-ident/tests/fst/xid_start.fst:86]
X: azure-proxy-agent source: very-long-line-length-in-source-file 922 > 512
[rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_sparse_crash-d07703ceb94b10dcd9e4acb809f2051420449e2b:1]
X: azure-proxy-agent source: very-long-line-length-in-source-file 924 > 512
[rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_sparse_crash-18cfc246f2ddfc3dfc92b0c7893178c7cf65efa9:1]
X: azure-proxy-agent source: very-long-line-length-in-source-file 933 > 512
[rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_sparse_crash-61fd8e3003bf9d99f6c1e5a8488727eefd234b98:1]
X: azure-proxy-agent source: very-long-line-length-in-source-file 941 > 512
[rust-vendor/regex-automata/tests/fuzz/testdata/deserialize_sparse_crash-0da59c0434eaf35e5a6b470fa9244bb79c72b000:1]
----------------------
As you can see, there's a lot of potential for improvement here. Please
fix as much as you can from that list, and override the false positives.
## Final Thoughts
This is a great start! It builds, and installs files in the right
locations. You're most of the way there, just some additional iterations
needed.
Thanks again for your work on this! Please do re-subscribe Ubuntu
Sponsors once you have an updated iteration, or if you have any
questions we can help answer.
Best wishes,
Simon
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2098393
Title:
[needs-packaging] azure-proxy-agent
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2098393/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
