Looks mostly good. There's just a few questions I have, but first, some basic facts just to give the questions some context:
hwe-qcom-x1e-meta depends on ubuntu-x1e-settings depends on ubuntu-x1e-settings-no-grub hwe-qcom-x1e-meta defines the modaliases that allow auto-selection of packages associated with the hardware Hence, presumably at the moment all hardware defined in -meta relies on GRUB to boot 1) Are there any devices that *don't* need -settings (e.g. which don't boot with GRUB)? 2) Thus, is there a possibility of adding another meta-package which would only depend on the -no-grub package? 3) Why split out the meta-package instead of defining the modaliases on the -settings package itself? 4) The maintscripts in -settings run update-grub but ignore if it fails. Is this desirable / normal? 5) The postinst maintscript in -settings refreshes the mesa and gnome content snaps to (presumably) hardware-specific channels. However it'll do this both on install *and upgrade*. Is this desirable? If, say, after installation the user manually switches gnome to an beta channel do we really want to force them back to stable when ubuntu-settings updates? This could be avoided by checking the $2 parameter (which refers to the old version in the case of upgrade, and is unset/blank in the case of fresh install) I'm assuming there are good reasons for all the above, that I'm just not understanding, but I'd like to understand before sponsoring. Now onto minor nitpicks which may optionally be worth addressing: 6) On a full build, lintian currently warns about "unknown field Modaliases". Seems this is just normal for XB- fields, and there's nothing wrong with the modaliases definition here, but it may be worth adding in a lintian-override just to make the build lintian clean. 7) Lintian in pedantic mode complains about lack of Rules-Requires-Root and that the copyright header uses http: instead of https: -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2091375 Title: [needs-packaging] ubuntu-x1e-settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2091375/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
