Review for Source Package: architecture-properties
[Summary]
This is a helper for cross-architecture packaging providing meta packages, such
as "architecture-is-64-bit" and wrapper functions calling into "qemu-user", to
execute binaries on a different architecture in the correct way. In total, it
consists of less than 150 lines of C/Shell/Make code and seems to be well
maintained as a native Debian package, including a Salsa CI pipeline.
MIR team ACK (under the constraint of having a look at the recommended
TODOs)
This does not need a security review
List of specific binary packages to be promoted to main: native-architecture
Specific binary packages built, but NOT to be promoted to main: <None>
Notes:
#0 - This is mostly a build-time helper tool, do we really need it in main, or
should we consider demoting reverse-depends (like libglib2.0-dev) to universe
instead?
#1 - To be used at its full potential (and fully tested in autopkgtests) we
might add this to the i386 whitelist.
Required TODOs:
- None
Recommended TODOs:
#2 - The package should get a team bug subscriber before being promoted
#3 - Think about test cases that could be added during build-time
#4 - Help fixing some of the lower priority Lintian warnings:
=> W: architecture-properties source: debhelper-but-no-misc-depends
=> I: architecture-properties source: out-of-date-standards-version 4.6.1
=> X: cross-exe-wrapper: executable-in-usr-lib (move to /usr/libexec ?)
[Rationale, Duplication and Ownership]
- There is no other package in main providing the same functionality.
- A team is committed to own long term maintenance of this package.
(~desktop-packages, potentially ~foundations-bugs)
- The rationale given in the report seems valid and useful for Ubuntu
[Dependencies]
OK:
- no other Dependencies to MIR due to this
- SRCPKG checked with `check-mir`
- all dependencies can be found in `seeded-in-ubuntu` (already in main)
- none of the (potentially auto-generated) dependencies (Depends
and Recommends) that are present after build are not in main
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
more tests now.
Problems: None
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard
Problems: None
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats from an untrusted source.
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography
- this makes appropriate (for its exposure) use of established risk
mitigation features (dropping permissions, using temporary environments,
restricted users/groups, seccomp, systemd isolation features,
apparmor, ...)
Problems: None
[Common blockers]
OK:
- does not FTBFS currently
- does have a non-trivial test suite that runs as autopkgtest
- This does not need special HW for build or test
- no new python2 dependency
- not a Python package
- not a Go package
Problems:
- does NOT have a test suite that runs at build time
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- debian/watch is not present but also not needed (e.g. native)
- Upstream update history: it's a native Debian package
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
maintained the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list
Problems:
- Debian/Ubuntu update history is sporadic
=> But it seems to be a low-maintenance package, encoding some knowledge,
that is only updated as needed.
- Lintian warning:
=> W: architecture-properties source: debhelper-but-no-misc-depends
=> I: architecture-properties source: out-of-date-standards-version 4.6.1
=> X: cross-exe-wrapper: executable-in-usr-lib (move to /usr/libexec ?)
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests)
- no use of user nobody
- no use of setuid / setgid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit or libseed
- not part of the UI for extra checks
- no translation present, but none needed for this case (user visible)?
Problems: None
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2080965
Title:
[MIR] architecture-properties
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/architecture-properties/+bug/2080965/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
