Thanks for the review @paelzer!

Below are some comments on your TODOs:

#1

[ QA ]
Besides like you mentioned multiple developers currently having access to the 
hardware and effectively testing all updates by hand, I would like to add a 
manual tests to https://git.launchpad.net/ubuntu-manual-tests?h=main as we have 
for Raspberry Pis. Those could specifically cover the configs from this package 
such as making sure the touch screen works, checking the mac and bluetooth hw 
addresses etc.

There is a bit of a chicken-egg problem because without this package the
installer won't work for this hardware.

#2, #3

I will investigate what we can improve here

#4

I understand that the options sound suspicious but there are good
reasons we set them. For reference here is a link to the documentation
from the Linaro engineer who did most of the bring-up and upstreaming
work: https://github.com/jhovold/linux/wiki/X13s#kernel-command-line

arm64.nopauth is required because the hardware announces support for
pointer authentication (and it probably has) but enabling it causes
firmware issues crashing the machine. This was briefly fixed in a
firmware update by Lenovo and later retracted again.

clk_ignore_ununsed and pd_ignore_unused are needed because there is an handover 
issue between bootloader and kernel. This is a hardware specific workaround 
until Linux grows a better way to handle this situation. 
For a more detailed explanation see 
https://youtu.be/qffWt4o334Y?feature=shared&t=1468

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2074078

Title:
  [MIR] ubuntu-x13s-settings

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-x13s-settings/+bug/2074078/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to