Thanks, Arif.
The contents are correct as per the upstream release.
For the `X-Python3-Version: >= 3.6` entry in d/control, I kept wondering
if it is this needed in anything other than bionic and I wonder how the
SRU team will look at that. Unless we are supporting upgrade paths that
would skip a release, e.g., upgrading directly from xenial to focal,
jammy, or noble, this would have no effect at all in all but a bionic
debdiff. No need to remove the entry though, I am just leaving this
comment as a note for the SRU review later (let the SRU team decide on
this one). Still, if you want to keep it, you will need to file the SRU
template paperwork in the related bug (LP: #2038648).
In oracular, the last patch added is now a variation of an upstream
commit so it applies correctly to the current version. In that case, you
can keep the original patch file with just that hunk that did not apply
removed. The Origin DEP3 header can be set to "backport,
GITHUB_COMMIT_URL".
I also have a nitpick for d/patches:
on the "Origin" DEP3 header field entries, would you mind pointing to commits
instead of PRs? this would make it clearer to whoever looks at the patch that
the change was already accepted upstream without the need to open the URLs to
verify if that is the case.
e.g., instead of
Origin: upstream, https://github.com/sosreport/sos/pull/3545
use
Origin: upstream,
https://github.com/sosreport/sos/commit/7e81246fcfd35e17a69bc3d40400cd123e8ca7bf
etc.
The mantic's debian/changelog file is missing entries for
python3-packaging and python3-yaml. I did not review jammy and focal
assuming they will also have similar instances of the cases listed
above. Let's get oracular in a "ready to upload" shape, then we can go
back fixing the SRUs, WDYT?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2054395
Title:
[sru] sos upstream 4.7.0
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-pro/+bug/2054395/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
