Thanks for the changes, Arif. I am reviewing the oracular changes only for now so we can get everyhing right in that one and then we can proceed to checking the SRU candidates.
- The changes still correctly match the upstream changes - The patches introduced correctly match their upstream references in the DEP3 headers. - The 0006* patch "Origin:" DEP3 header was set as "origin:" (no capital O). No need to fix this. I can change this one before uploading. - Now, for the "X-Python3-Version: >= 3.6" change: As I mentioned, I will leave this for the SRU team to decide whether this is an acceptable change for all series or not. Do note that the bug that this solves is only present in bionic. These changes are not targeting bionic at all, i.e., LP: #2038648 is not being fixed by these changes. This means that even if I upload this to the stable series, there is a chance that the SRU team will reject it and you will need to re-work things, find an uploader/sponsor again an go through this process once more. However, this is definitely OK to push to oracular, no objections here. Finally, note that the changelog entry is mentioning a bug (LP: #2038648) that is not being fixed here (since the bug only affects bionic). Hence, I will remove the ":" in the LP reference to the python3-version bug above so it will not be parsed by any launchpad automation (given there is no target to close). If you agree with the 2 minor changes I am proposing (the capital O in the patch, and changing (LP: #2038648) to (LP #2038648), I will go ahead and upload this to oracular. - Do you agree with the 2 minor changes + upload to oracular? - Do you want me to go ahead and proceed with reviewing (and possibly uploading everything to) the stable branch debdiffs or would you like to review that python3 dependency bug/change? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2054395 Title: [sru] sos upstream 4.7.0 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-pro/+bug/2054395/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
