** Description changed: [Impact] - This is to consider/discuss the possibility of whether the Ceph packages (UCA) should be built with RelWithDebInfo build option (CMAKE_BUILD_TYPE [0]) which can be supplied to the build script do_cmake.sh [1]. + This is to build the Ceph packages (UCA) with 'RelWithDebInfo' build option (CMAKE_BUILD_TYPE [0]) which can be supplied to the build script do_cmake.sh [0]. - Currently, Upstream as well as UCA builds default to 'Debug' [0] builds. - But is any reason why shouldn't go for RelWithDebInfo (i.e. "Release - with Debug information")? + Currently, UCA builds default to 'Debug' [1] builds. The UCA's build process does debug build just for the rocksdb component - because the upstream builds (CMakeLists.txt) left it to individual projects using rocksdb. So UCA's build used the default (debug build). Upstream has since + updated this to do release build (with RelWithDebInfo option) [2]. - There's one issue noted with RelWithDebInfo which has a workaround, too - [2]. - - In general, gcc's -O2 [3] build should generate better code as well as - there's a specific case for Ceph [4] that it improves performance. + In general, gcc's -O2 [3] (which will be enabled by RelWithDebInfo) + build should generate better code as well as there's a specific case for + Ceph [4] that it improves performance. Building rocksdb with optimizations enabled improves the performance and rocksdb being an important part of OSD and MON components of Ceph, this enables better performance of Ceph cluster. Comments #17, #18, & #19 show relevant test results. - [0] https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html + [Test Case] + Standard ceph-backed OpenStack regression will be run, consisting of juju-deployed OpenStack+ceph and tempest regression testing against the deployment. - [1] https://github.com/ceph/ceph/blob/master/do_cmake.sh + [Regression Potential] + As Ponnuvel mentioned, the size of binaries will be slightly bigger and also the build/compilation will be longer. - [2] https://docs.ceph.com/docs/master/dev/perf/#common-issues + There are no upstream bugs for this. rocksdb is one of the submodules in + Ceph and how each of the submodule gets built is left to end-users. The + bug [5] where this change was done in upstream is not relevant directly; + this change was done as part of a different bug fix. + + [0] https://github.com/ceph/ceph/blob/master/do_cmake.sh + + [1] https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html + + [2] https://github.com/facebook/rocksdb/pull/5916 [3] https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html [4] https://bugs.gentoo.org/show_bug.cgi?id=733316 - [Test Case] - Standard ceph-backed OpenStack regression will be run, consisting of juju-deployed OpenStack+ceph and tempest regression testing against the deployment. - - [Regression Potential] - As Ponnuvel mentioned, the size of binaries will be slightly bigger and also the build/compilation will be longer. - There are no upstream bugs for this. rocksdb is one of the submodules in Ceph and how each of the submodule gets built is left to end-users. + [5] https://github.com/facebook/rocksdb/issues/2445
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1894453 Title: Building Ceph packages with RelWithDebInfo To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1894453/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
