(In reply to :Gijs (Not available 3-19 Aug; he/him) from comment #50) > (In reply to Amy Lee [:amylee] UX from comment #49) > > (In reply to :Gijs (Not available 3-19 Aug; he/him) from comment #48) > > > Second, users who are used to the current behavior with session restore > > > enabled (esp. on Windows, where mis-hitting ctrl-shift-q is also not a > > > major > > > concern) will start getting warning dialogs when we implement the new > > > behavior. That seems disruptive. But we can't turn off the warning > > > everywhere because then they won't get a warning when closing a window, > > > which they might have relied upon. Any thoughts about how to address that? > > > > The default settings of Session Restore would be what we have currently (not > > having warnings). > > That's not really what happens today. Today, there are warnings when closing > windows, or using "close tabs to the right", or using "close other tabs" - > but not when quitting, if and only if session restore is enabled. > > Specifically, the preference you're suggesting we surface "under" Restore > Previous Session already exists, and its default is true (ie warn when > closing tabs). However, there are hardcoded checks for "does the user have > session restore enabled?" in the code that avoid warning when quitting, > irrespective of whether the "warn when closing tabs" checkbox is checked. > > In your new design, we'd remove the hardcoded checks to ask session restore > in the code that actually implements warning, and cosmetically we'd move the > checkbox in about:preferences, and add some logic to tick/untick (and > set/unset the pref) when the user toggles restoring their session. But that > doesn't solve the conundrum here - the pref would be turned on by default, > and we'd remove the checks, so then the user will start getting warnings. > > We could have a one-time migration that turns off the "warn when closing > tabs" pref for people who have session restore turned on, but that also > seems like it'd potentially confuse users who would no longer see warnings > when closing windows / multiple tabs (e.g. via "close tabs to the right") > where they did see those before. > > What would you prefer we do? Disable the warnings everywhere for session > restore users, or accept that we'll now start warning session restore users > who might not have expected this?
I would say accept that we'll now start warning session restore users about quitting. They have the option on the warning message to disable it if they want to. I've changed the wording slightly in the preference to include "quitting" when enabling warning on closing multiple tabs. If a user quits the browser with multiple tabs opened they should get this warning as well cause technically they are still closing multiple tabs when quitting. I've attached an updated spec. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
