Yeah, that patch seems fine, although maybe incomplete.  The fopen call
in that same function (and sister function io_get_regular_file_size)
aren't checked for errors either, meaning we'd pass fseek and fread a
NULL pointer.  I don't know off hand what behavior is there.  But these
are actually minor issues.  They only happen after already opening and
closing the file for read access.  So it would have to be a race
condition that deletes or chmods the file between calls.  Probably not a
big deal in foma's use cases.  I wouldn't bother patching out of sync
with Debian on this.

Ubuntu Finland Web Developers is the team looking after this?  I didn't
expect that...  Are you the only person in that team with upload rights
for this package?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1544453

Title:
  [MIR] foma (and demote malaga)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/foma/+bug/1544453/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to