> > - would be nice to pass -i to dh_* calls in binary-indep
> Hmm, why would that be nice? Doesn't look like it's necessary.

By default, dh_* commands act on all packages of debian/control;
currently you only have Arch: all packages, so all packages equals all
arch indep packages.  IOW you're calling a command acting on arch indep
and arch specific packages in an arch indep target (binary-indep).  But
it's just a nice to have to fix this because you would certainly notice
if you were to add some arch specific packages (hopefully ;-).

> Fixed. I tried to handle this by ensuring that the user owned the file,
> with the -O test. I thought that would make it safe? Well, in any case,
> I've moved this to $HOME/.screenrc-updates-available. This is only really
> ever used in <jaunty code. It's here so that I don't have to compile
> separate binaries for hardy/intrepid/jaunty.

You can only check the owner if the file exists; when the file didn't
exist, you would create it: this created a window where another user /
process could create the symlink.


There's a regression in your new upload:
W: screen-profiles source: package-lacks-versioned-build-depends-on-debhelper 6
(you're using compat 6).


One thing which would be nice to do is to use the Description to explain why 
update-notifier-common and bc are useful dependencies to install (since these 
are optional).

Albeit probably useless by most metrics, you could add an "Enhances:
screen".

You don't need to pass debian/screen-profiles debian/files debian
/screen-profiles.debhelper.log to dh_clean, it cleans these by default.

You should use dpkg-parsechangelog to parse debian/changelog instead of seds.
DEBVERSION := $(shell dpkg-parsechangelog | sed -n -e 's/^Version: //p')
VERSION := $(shell echo $(DEBVERSION) | sed -e 's/-[^-]*$$//')
careful: doesn't strip epochs.

-- 
main inclusion: screen-profiles
https://bugs.launchpad.net/bugs/317214
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to