Packaging:
- you bdep on gettext and po4a, but these are only used in prebuild which isn't
called on the buildds
- get-orig-source has:
[ -d ../../${PACKAGE} ] && mv ../../${PACKAGE} ../../${PACKAGE}-${VER}
|| true
you can use a leading "-" to disable error checking:
-[ -d ../../${PACKAGE} ] && mv ../../${PACKAGE} ../../${PACKAGE}-${VER}
or even better, honor errors:
[ ! -d ../../${PACKAGE} ] || mv ../../${PACKAGE} ../../${PACKAGE}-${VER}
(or use if then fi)
- There's a bunch of ../../ in the get-orig-source rule; I understand it needs
to be called from the debian/ dir; perhaps you should enforce this just like
dh_testdir does (or require that the rule be run as "debian/rules
get-orig-source" and use dh_testdir itself).
- clean:
rm -rf debian/${PACKAGE} debian/files debian/${PACKAGE}.debhelper.log
I think you want dh_clean?!?
- would be nice to pass -i to dh_* calls in binary-indep
- get-orig-source is .PHONY
- you don't need dh_installdirs / debian/dirs
- you miss a dh_md5sums call
- you should depend on ${misc:Depends} with debhelper >= 5
This is what lintian has to say:
I: screen-profiles source: debian-watch-file-is-missing
W: screen-profiles source: debhelper-but-no-misc-depends screen-profiles
I: screen-profiles source: build-depends-without-arch-dep debhelper
I: screen-profiles source: build-depends-without-arch-dep gettext
I: screen-profiles source: build-depends-without-arch-dep po4a
W: screen-profiles: binary-without-manpage usr/bin/screen-launcher
W: screen-profiles: binary-without-manpage usr/bin/screen-profiles-helper
I: screen-profiles: no-md5sums-control-file
These are covered in the above remarks more or less.
Please mention the copyrights of Canonical and Nick Barcet.
Typo in man page:
select-screen-profile is an application lists the available screen pro‐
files on a system and prompts the user to select one.
("which lists" perhaps?)
Would be nice to use "set -e" in non-trivial shell scripts.
mycache=/var/tmp/updates-available-$USER is a very bad idea: /var/tmp is
+t and anybody can write there; I can create a /var/tmp/updates-
available-root symlink to /etc/shadow as my user and wait for updates-
available to be run as root.
You need to find another place, or another mechanism. For instance you
could source all files /var/tmp/updates-available-$USER-XXXXXXXX which
are owned by $USER and take the most recent one, delete the others.
--
main inclusion: screen-profiles
https://bugs.launchpad.net/bugs/317214
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
