Updated patch: moved SymLink() back to where it was; added a prototype before the first function that uses it. Used asprintf() instead of calloc/strcat/strcat, and added a configure check for that function. I used a loop to resolve symlinks because that's what the source does in main(), and I figured I'd use the patterns that the original coder used elsewhere. (SymLink() itself does call realpath().) I wanted to change the existing code style as little as possible.
I've already forwarded this (via email; there's no active upstream bugtracker) along with the initial version of the patch. I'm attaching the revised patch, and I'll also send it upstream. Thanks for the review, and please let me know if you have any other updates or suggestions. ** Attachment added: "Revised patch, per Martin Pitt's advice." http://launchpadlibrarian.net/17883393/eject-264071-v2.diff -- eject -X reports "error while finding CD-ROM name". https://bugs.launchpad.net/bugs/264071 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
