Some issues:
 - why does the patch move around the Symlink() function? That's confusing and 
unnecessary IMHO. If you need it earlier, maybe just add a prototype?
 - calloc/strcat/strcat could be replaced with a single asprintf() to improve 
readability and robustness
 - resolving symlinks should be done with realpath(3), instead of doing a loop 
all by yourself
 - can you please report this to upstream?

** Changed in: eject (Ubuntu)
       Status: Confirmed => Incomplete

-- 
eject -X reports "error while finding CD-ROM name".
https://bugs.launchpad.net/bugs/264071
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to