Review: Approve

Hey Octa, thanks for fixing this. I've merged the branch.

[warning, awk nerdery] awk can be used to comput the max priority directly, 
like so:

  apt-cache policy | awk 'BEGIN{max=0} /^ [0-9]+ / {if ($1 > max) max = $1} 
END{print max}'

I *think* the quoting would need to look something like (but my simple attempts 
to make it work failed):

  bash -c "echo $(apt-cache policy | awk 'BEGIN{max=0} /^ [0-9]+ / {if ($1 > 
max) max = $1} END{print max}')"

Also, learning to ammend commits and/or rebase -i so we don't have all the 
adjusting commits in the history would be nice to consider in the future 
(force-pushing a shared common branch will break things, but force-pushing to 
overwrite a merge proposal branch is acceptable, and launchpad's merge request 
interface will handle it okayish; for example I've reworked and rebased on 
master the branch at 
https://code.launchpad.net/~sbeattie/qa-regression-testing/+git/qa-regression-testing/+merge/467433
 multiple times now).
-- 
https://code.launchpad.net/~octagalland/ubuntu-qa-tools/+git/ubuntu-qa-tools/+merge/470446
Your team Ubuntu Bug Control is subscribed to branch ubuntu-qa-tools:master.


_______________________________________________
Mailing list: https://launchpad.net/~ubuntu-bugcontrol
Post to     : ubuntu-bugcontrol@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-bugcontrol
More help   : https://help.launchpad.net/ListHelp

Reply via email to