Hi Wolfgang, On Sat, Nov 3, 2012 at 8:04 AM, Wolfgang Denk <[email protected]> wrote: > Dear Simon Glass, > > In message > <CAPnjgZ2hD4ZgzM=0rppsgr0-iojtv+q40e3gyexeqxndkop...@mail.gmail.com> you > wrote: >> >> >> > --- /dev/null >> >> > +++ b/common/cmd_cbfs.c >> >> > @@ -0,0 +1,214 @@ >> >> > +/* >> >> > + * Copyright (c) 2011 The Chromium OS Authors. All rights reserved. >> >> > + * >> >> > + * See file CREDITS for list of people who contributed to this >> >> > + * project. >> >> >> >> file CREDITS ? Please fix globally... >> >> >> >> >> >> Is any of this code taken from any other project? If yes, then please >> >> attribute properly... >> > >> > Sorry? U-Boot has a CREDITS file but only ~10% of the files reference >> > it. > > Yes, U-Boot has such a file, and I wonder if we should remove it. > After all, all the credits are maintained in the git history of > changes. > >> Tom or Wolfgang, can you please explain what I should do here? I don't >> know what to do about the CREDITS line. > > To me the reference to a CREDITS file is reason to suspect that this > code has not been written from scratch, but copied from some other > project, which eventually had it's own CREDITS file.
Yes, quite likely the boilerplate came from another U-Boot file. > > I'm missing a reference to the origin of the code. It was written from scratch by Gabe - it did not come from coreboot if that is what you as asking. I confirmed with him again yesterday. > > If this was indeed written from scratch, with no code borrowed from > elsewhere, then please just drop these lines. OK, I will do this in my follow-up patch to add DocBook support. I did find a shorter message which some U-Boot files use at one point. I will try to find that again, and use it. Regards, Simon > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] > "Text processing has made it possible to right-justify any idea, even > one which cannot be justified on any other grounds." > -- J. Finnegan, USC. _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
