Hi Wolfgang, On Sat, Nov 3, 2012 at 8:00 AM, Wolfgang Denk <w...@denx.de> wrote: > Dear Simon Glass, > > In message <1351874667-23959-1-git-send-email-...@chromium.org> you wrote: >> From: Taylor Hutt <th...@chromium.org> >> >> When building for the Sandbox version, the casts in this change are >> necessary to avoid compilation issues. >> >> Signed-off-by: Taylor Hutt <th...@chromium.org> >> Signed-off-by: Simon Glass <s...@chromium.org> >> --- >> drivers/tpm/generic_lpc_tpm.c | 10 +++++----- >> 1 files changed, 5 insertions(+), 5 deletions(-) > > I see little sense in spending work on this code. After all the time, > it is still unused and dead code in mainline - there is not a single > configuration which actually enables the necessary CONFIG_ options., > > I recommend to remove the whole TPM code instead.
It is actually used in the x86 Chromebook, but the patch to enable it never made it to mainline. There was quite a bit of push-back on the x86 side at the time and the person working on it finally had enough :-( I have recently taken this up again to see if we can get x86 into a better state for newer Intel chips and the latest x86 Chromebooks. The patch to enable the TPM there is: http://patchwork.ozlabs.org/patch/190813/ The patch to enable on ARM Chromebooks is the third patch in this TPM series: http://patchwork.ozlabs.org/patch/196596/ I accept that it has sat there for a while without a board config to use it. But I would very much like to keep this code and see no sense in removing it now that it is actually in use. Regards, Simon > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > You are an excellent tactician, Captain. You let your second in com- > mand attack while you sit and watch for weakness. > -- Khan Noonian Singh, "Space Seed", stardate 3141.9 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
