Dear Marek Vasut,

In message <1350470636-7625-1-git-send-email-ma...@denx.de> you wrote:
> This patch adds essential components for generation of the contents of
> the linker section that is used by the linker-generated array. All of
> the contents is held in a separate file, u-boot.lst, which is generated
> at runtime just before U-Boot is linked.
...
> --- a/Makefile
> +++ b/Makefile
> @@ -535,7 +535,10 @@ else
>  GEN_UBOOT = \
>               UNDEF_SYM=`$(OBJDUMP) -x $(LIBBOARD) $(LIBS) | \
>               sed  -n -e 
> 's/.*\($(SYM_PREFIX)__u_boot_cmd_.*\)/-u\1/p'|sort|uniq`;\
> -             cd $(LNDIR) && $(LD) $(LDFLAGS) $(LDFLAGS_$(@F)) $$UNDEF_SYM 
> $(__OBJS) \
> +             UNDEF_LST=`$(OBJDUMP) -x $(LIBBOARD) $(LIBS) | \
> +             sed  -n -e 
> 's/.*\($(SYM_PREFIX)_u_boot_list_.*\)/-u\1/p'|sort|uniq`;\

Maybe we can sae one call to objdump by storing the intermediate
result?

> +             cd $(LNDIR) && $(LD) $(LDFLAGS) $(LDFLAGS_$(@F)) \
> +                     $$UNDEF_SYM $$UNDEF_LST $(__OBJS) \

Hm.... we use UNDEF_SYM and UNDEF_LST in exactly the same way?  The
why cannot we do this all in a single run, like:

        UNDEF_SYM=`$(OBJDUMP) -x $(LIBBOARD) $(LIBS) | \
        sed  -n -e 's/.*\($(SYM_PREFIX)__u_boot_cmd_.*\)/-u\1/p' \
                -e 's/.*\($(SYM_PREFIX)_u_boot_list_.*\)/-u\1/p' | sort | 
uniq`;\
        cd $(LNDIR) && $(LD) $(LDFLAGS) $(LDFLAGS_$(@F)) $$UNDEF_SYM $(__OBJS) \
        ...

?

>       @rm -f $(obj)board/cray/L1/{bootscript.c,bootscript.image}        \
>              $(obj)board/matrix_vision/*/bootscript.img                 \
>              $(obj)board/voiceblue/eeprom                               \
> -            $(obj)u-boot.lds                                           \
> +            $(obj)u-boot.lds,include/u-boot.lst                        \

s/,/ / here!!!

> +     @rm -f 
> $(obj)nand_spl/{u-boot.{lds,lst},u-boot-nand_spl.lds,u-boot-spl,u-boot-spl.map,System.map}
> +     @rm -f 
> $(obj)spl/{u-boot-spl,u-boot-spl.bin,u-boot-spl.{lds,lst},u-boot-spl.map}

Line length?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
"There are some good people in it, but the orchestra as  a  whole  is
equivalent to a gang bent on destruction."      - John Cage, composer
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to