Hi Albert, On 10/15/2012 04:01 PM, Albert ARIBAUD wrote: > Hi Jaehoon, > >>>> + desc->des0 = des0; >>>> + desc->des1 = des1; >>>> + desc->des2 = des2; >>>> + desc->des3 = (unsigned int)desc + sizeof(struct dwmci_idmac); >>> >>> >>> Also, is there a reason that you've decided to label the 4 fields of >>> your descriptor (which appear to reflect flags, count, address, >>> pointer to next descriptor) as des0-3? >> In DesigneWare IP spec, descriptors are used to those label. > > Makes the code pretty cryptic. Better name the struct membder by their > function and comment with their IP spec designations, or maybe name > them by both their IP name and function, e.g. desc->des0_flags, > desc->des1_count etc. > > But in any case, local variables (des0, des1...) have zero reason to > be named after the IP spec. These must be renamed according to their > function. Thanks for your comment. I will modify that...e.g. desc->flags/cnt/cur_addr/next_addr or others.
Best Regards, Jaehoon Chung > > Amicalement, > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
