Dear Piotr and Joonyoung, On 11 October 2012 17:14, Piotr Wilczek <p.wilc...@samsung.com> wrote: > Hi Joonyoung, > >> -----Original Message----- >> From: Joonyoung Shim [mailto:dofm...@gmail.com] >> Sent: Thursday, October 11, 2012 3:11 AM >> To: Piotr Wilczek >> Cc: u-boot@lists.denx.de; Kyungmin Park >> Subject: Re: [U-Boot] [PATCH 2/5] EXYNOS: Add Exynos4 I2C spacing >> >> Hi, Protr. >> >> 2012/9/24 Piotr Wilczek <p.wilc...@samsung.com>: >> > This patch add the spacing for i2c for Exynos4 >> > >> > Signed-off-by: Piotr Wilczek <p.wilc...@samsung.com> >> > Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com> >> > CC: Minkyu Kang <mk7.k...@samsung.com> >> > --- >> > arch/arm/include/asm/arch-exynos/cpu.h | 2 ++ >> > 1 files changed, 2 insertions(+), 0 deletions(-) >> > >> > diff --git a/arch/arm/include/asm/arch-exynos/cpu.h >> > b/arch/arm/include/asm/arch-exynos/cpu.h >> > index 5056b37..b70273c 100644 >> > --- a/arch/arm/include/asm/arch-exynos/cpu.h >> > +++ b/arch/arm/include/asm/arch-exynos/cpu.h >> > @@ -28,6 +28,8 @@ >> > #define EXYNOS4_ADDR_BASE 0x10000000 >> > >> > /* EXYNOS4 */ >> > +#define EXYNOS4_I2C_SPACING 0x10000 >> > + >> >> Also EXYNOS5_I2C_SPACING is 0x10000, so how about define just >> EXYNOS_I2C_SPACING for both EXYNOS4 and EXYNOS5? > I agree it would simplify the code (s3c24x0_i2c driver). On the other hand, > for code readability, maybe it is better to keep them separate as we do so > with all defines for each Exynos. >
I agreed with Piotr. Thanks Minkyu Kang. -- from. prom. www.promsoft.net _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
