On 10/02/2012 04:45 PM, Tom Warren wrote:
> These are stripped down for bringup, They'll be filled out later
> to match-up with the kernel DT contents, and/or as devices are
> brought up (mmc, usb, spi, etc.).

> diff --git a/arch/arm/dts/tegra30.dtsi b/arch/arm/dts/tegra30.dtsi

> +/include/ "skeleton.dtsi"
> +
> +/ {
> +     model = "NVIDIA Tegra30";
> +     compatible = "nvidia,tegra30";
> +
> +     clocks {
> +             #address-cells = <1>;
> +             #size-cells = <0>;
> +
> +             osc: clock {
> +                     compatible = "fixed-clock";
> +                     #clock-cells = <0>;
> +             };
> +     };

Nothing uses any of the clock stuff; I don't think we should add this
until it's needed.

> +     gpio: gpio@6000d000 {
> +             compatible = "nvidia,tegra30-gpio", "nvidia,tegra20-gpio";
> +             reg = <0x6000d000 0x1000>;
> +             #gpio-cells = <2>;
> +             gpio-controller;
> +     };

Similarly, nothing uses this.

> +     serial@70006000 {
> +             compatible = "nvidia,tegra30-uart", "nvidia,tegra20-uart";
> +             reg = <0x70006000 0x40>;
> +             reg-shift = <2>;

This needs the following extra line here:

                interrupts = <0 36 0x04>;

> +             status = "disabled";
> +     };

Although again, nothing uses this, so may as well omit it.

> diff --git a/board/nvidia/dts/tegra30-cardhu.dts 
> b/board/nvidia/dts/tegra30-cardhu.dts
> new file mode 100644
> index 0000000..68563e8
> --- /dev/null
> +++ b/board/nvidia/dts/tegra30-cardhu.dts
> @@ -0,0 +1,35 @@
> +/dts-v1/;
> +
> +/memreserve/ 0x1c000000 0x04000000;
> +/include/ ARCH_CPU_DTS
> +
> +/ {
> +     model = "NVIDIA Cardhu";
> +     compatible = "nvidia,cardhu", "nvidia,tegra30";
> +
> +     aliases {
> +     };

May as well leave that out until it's needed.

> +        memory {
> +                device_type = "memory";
> +                reg = <0x80000000 0xc0000000>;
> +        };

There's an indentation error there.

> +
> +     clocks {
> +             clk_32k: clk_32k {
> +                     clock_frequency = <32000>;
> +             };
> +             osc {
> +                     clock-frequency = <12000000>;
> +             };
> +     };
> +
> +     clock@60006000 {
> +             clocks = <&clk_32k &osc>;
> +     };
> +
> +     serial@70006000 {
> +             status = "ok";
> +             clock-frequency = < 216000000 >;
> +     };
> +};

Similarly, I don't think anything uses any of that.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to