Stephen, On Wed, Oct 3, 2012 at 11:26 AM, Stephen Warren <swar...@wwwdotorg.org> wrote: > On 10/02/2012 04:45 PM, Tom Warren wrote: >> These files are for code that runs on the CPU (A9) on T30 boards. >> At this time, it's only the RCM (Recovery Mode) cmd file, which >> is in tegra-common. As T30-specific run-time code is added, it'll >> go here. > >> diff --git a/arch/arm/cpu/arm720t/tegra30/Makefile >> b/arch/arm/cpu/armv7/tegra30/Makefile > >> -LIB = $(obj)lib$(SOC).o >> +LIB = $(obj)lib$(SOC).o > > Looks like there are two spaces after the = there. > >> -all: $(obj).depend $(LIB) >> +all: $(obj).depend $(LIB) > > And a space after the TAB there.
Right on both counts. Despite what git format-patch said about the origin of this file, it was really copied over from armv7/tegra20/Makefile, and the spacing errors are in that file originally. Guess checkpatch doesn't look at Makefiles. I'll correct this on the next rev. Thanks. > > Does U-Boot compile at this point in the series? Hopefully "git bisect" > is maintained across the series. I suppose there aren't any boards.cfg > entries for Tegra30 yet, so the fact that e.g. CONFIG_ARCH_DEVICE_TREE > points at a file that doesn't yet exist is impossible to notice. I haven't done a git bisect on the series, but I did do individual git am's on each patch with ./MAKEALL -s tegra20 between each, and saw no problems when I did the first port. I did go in and rebase/amend a few commits, though, during a final clean-up effort, so I may have broken bisect. I'll be sure to test each patch/bisect on the next rev. Thanks, Tom _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
