Dear Łukasz Dałek, > On 27.09.2012 02:06, Marek Vasut wrote: > > Dear Łukasz Dałek, > > > >> On 27.09.2012 01:58, Marek Vasut wrote: > >>> Dear Łukasz Dałek, > >>> > >>>> On 26.09.2012 17:31, Marek Vasut wrote: > >>>>> Dear Lukasz Dalek, > >>>>> > >>>>>> PXA25x gadget implements common function usb_disconnect(). > >>>>>> This patch adds this function prototype into usb.h for boards using > >>>>>> it. > >>>>> > >>>>> [...] > >>>>> > >>>>>> +/* > >>>>>> + * This isn't host > >>>>>> + */ > >>>>> > >>>>> The comment doesn't need to be multiline. It'd be cool if it was > >>>>> meaningful ... like "pxa25x can only do gadget mode, thus the > >>>>> following ... etc". Otherwise, we're basically there. > >>>> > >>>> Ok > >>>> > >>>>> Can you repost the whole patchset please? > >>>> > >>>> Whole? Including ethernet driver, pxa cpu detection etc...? > >>>> If so, I'll resend them. > >>> > >>> Yes, in correct order please. We're almost there now. > >>> > >>> btw. do you want to hack further on uboot? Maybe some PXA improvements > >>> cleanups etc? > >> > >> Yes, but before I want to complete what I've started with h2200... > > > > You're basically there! > > What do you mean saying that I am there?
That you've walked most of the journey already, there's only the one small final step for you to do ... > > btw sorry if I sound a bit crazy, I've been pretty loaded recently so I > > might have forgotten what I have told you a few days ago ... > > No problem. > > Łukasz Dałek Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
