On 26.09.2012 17:31, Marek Vasut wrote:
Dear Lukasz Dalek,

PXA25x gadget implements common function usb_disconnect().
This patch adds this function prototype into usb.h for boards using it.
[...]

+/*
+ * This isn't host
+ */
The comment doesn't need to be multiline. It'd be cool if it was meaningful ...
like "pxa25x can only do gadget mode, thus the following ... etc". Otherwise,
we're basically there.

Ok


Can you repost the whole patchset please?

Whole? Including ethernet driver, pxa cpu detection etc...?
If so, I'll resend them.

Łukasz Dałek
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to