On 22/09/2012 19:07, Troy Kisky wrote: > On 9/21/2012 7:50 PM, Fabio Estevam wrote: >> Hi Troy, >> >> On Fri, Sep 21, 2012 at 11:39 PM, Troy Kisky >> <troy.ki...@boundarydevices.com> wrote: >>> Add function to return the processor type. >>> >>> i.e. MX6Q, MX6DL, MX6SOLO, MX6SOLOLITE >> On arch/arm/imx-common/cpu.c we have: >> >> static const char *get_imx_type(u32 imxtype) >> { >> switch (imxtype) { >> case 0x63: >> return "6Q"; /* Quad-core version of the mx6 */ >> case 0x61: >> return "6DS"; /* Dual/Solo version of the mx6 */ >> case 0x60: >> return "6SL"; /* Solo-Lite version of the mx6 */ >> case 0x51: >> return "51"; >> case 0x53: >> return "53"; >> default: >> return "??"; >> } >> } >> >> ,which seems to serve the same purpose. >> >> Regards, >> >> Fabio Estevam >> > > No, not similar to get_imx_type, but it is similar to get_cpu_rev. > > I guess I should fix get_imx_type, and get_cpu_rev, instead of > adding a new one. >
Indeed. Try to use as much as possible code in imx-common, avoiding to duplicate code. Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot